From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] DRM: Armada: Use devm_ioremap_resource() Date: Mon, 7 Apr 2014 12:53:18 +0200 Message-ID: <20140407105316.GF25718@ulmo> References: <001e01cf4ed3$ff410170$fdc30450$%han@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1397838954==" Return-path: Received: from mail-bk0-f42.google.com (mail-bk0-f42.google.com [209.85.214.42]) by gabe.freedesktop.org (Postfix) with ESMTP id C7B4E6E5C4 for ; Mon, 7 Apr 2014 03:54:08 -0700 (PDT) Received: by mail-bk0-f42.google.com with SMTP id mx12so644808bkb.15 for ; Mon, 07 Apr 2014 03:54:07 -0700 (PDT) In-Reply-To: <001e01cf4ed3$ff410170$fdc30450$%han@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jingoo Han Cc: 'Russell King' , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1397838954== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5CUMAwwhRxlRszMD" Content-Disposition: inline --5CUMAwwhRxlRszMD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 03, 2014 at 09:31:04AM +0900, Jingoo Han wrote: > Use devm_ioremap_resource() because devm_request_and_ioremap() is > obsoleted by devm_ioremap_resource(). >=20 > Signed-off-by: Jingoo Han > --- > drivers/gpu/drm/armada/armada_crtc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armad= a/armada_crtc.c > index d8e3982..23b0123 100644 > --- a/drivers/gpu/drm/armada/armada_crtc.c > +++ b/drivers/gpu/drm/armada/armada_crtc.c > @@ -1037,10 +1037,10 @@ int armada_drm_crtc_create(struct drm_device *dev= , unsigned num, > if (ret) > return ret; > =20 > - base =3D devm_request_and_ioremap(dev->dev, res); > - if (!base) { > + base =3D devm_ioremap_resource(dev->dev, res); > + if (IS_ERR(base)) { > DRM_ERROR("failed to ioremap register\n"); > - return -ENOMEM; > + return PTR_ERR(base); While at it, perhaps you should drop the error message too because devm_ioremap_resource() already prints one in all failure cases. Thierry --5CUMAwwhRxlRszMD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTQoOcAAoJEN0jrNd/PrOh5EQP/A2QSZA/GPlO4cF6hcDuzrGb rLEHPDh7VCZQM2RM/FvO+HV/cfUxvcus1uyZiCwr7c2sc9xd+Daq4st/OBNwkmlU fXSzG0Lfd5EYlWlxsrFSlm0VZkMN3AIkP3b6uFEbnu7i0YPq0OdAgeontC6fJ+YI 1oUPVqR+IZZJ7FE7EVN6L7jtnWw2+QlU5nKGIUQWktoEyg1AFQwidUes31ovrkBQ GX5sDEP0TDA8QJUyWVcEBIQ1yJuhYWU6EugyPVwZMgk+wVNYGeFkEpxUYp6awc1C InG2VhBvKHm0l6EshqUU1MPReVibdfXImFyXK2JVd2bCYpELXGu5MhobQFt62C9c oa+8w8lK7lmlLI/Bfr7Av29LjRoF+q+ebDOoumLYy0xgiD2f7MHJTfkfdlWzUfZc q1ljbdjohT8Qi2/sf5VgAn37DHZCZs7zDAXhtFOk5d3E5qd2f3Eqg/+NUipqtBIg 7BGjgn29tHGbHgouwyIsUUdHz1jXSZliDmzRkTTvLBRaP+WDLBJDWWKP3e/DLrNO BkoXnkcjtzSWCtCX++H4sCfJF/3cJYigtOo2AWnoP6Rt3ebJuFsmgvncOk7nWsuE ydXXEtWHOAMMy40j+FdmrnvBfIxWyTDi9dvk5KD48Yy5HQOR6kPQ0djelHvLl+kL 5eEcYimm2EhT8IlP3AqE =r5E+ -----END PGP SIGNATURE----- --5CUMAwwhRxlRszMD-- --===============1397838954== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1397838954==--