From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:34569 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754760AbaDGOjx (ORCPT ); Mon, 7 Apr 2014 10:39:53 -0400 Date: Mon, 7 Apr 2014 15:38:50 +0100 From: One Thousand Gnomes To: Liviu Dudau Cc: Bjorn Helgaas , linux-pci , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , linaro-kernel , Arnd Bergmann , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely Subject: Re: [PATCH v7 5/6] pci: Export find_pci_host_bridge() function. Message-ID: <20140407153850.3c9ef3e5@alan.etchedpixels.co.uk> In-Reply-To: <20140407142045.GO17163@e106497-lin.cambridge.arm.com> References: <1394811272-1547-1-git-send-email-Liviu.Dudau@arm.com> <1394811272-1547-6-git-send-email-Liviu.Dudau@arm.com> <20140404233948.GC15806@google.com> <20140407142045.GO17163@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: > > If we *do* export it, I'd like it to have a more conventional name, e.g., > > something starting with "pci_". > > Understood. pci_find_host_bridge() ? pci_get_host_bridge() and take a reference IMHO ? If your primary bus is not PCI then your PCI "host" bridge could be hot swappable so the API at least ought to get that right. Alan From mboxrd@z Thu Jan 1 00:00:00 1970 From: gnomes@lxorguk.ukuu.org.uk (One Thousand Gnomes) Date: Mon, 7 Apr 2014 15:38:50 +0100 Subject: [PATCH v7 5/6] pci: Export find_pci_host_bridge() function. In-Reply-To: <20140407142045.GO17163@e106497-lin.cambridge.arm.com> References: <1394811272-1547-1-git-send-email-Liviu.Dudau@arm.com> <1394811272-1547-6-git-send-email-Liviu.Dudau@arm.com> <20140404233948.GC15806@google.com> <20140407142045.GO17163@e106497-lin.cambridge.arm.com> Message-ID: <20140407153850.3c9ef3e5@alan.etchedpixels.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > If we *do* export it, I'd like it to have a more conventional name, e.g., > > something starting with "pci_". > > Understood. pci_find_host_bridge() ? pci_get_host_bridge() and take a reference IMHO ? If your primary bus is not PCI then your PCI "host" bridge could be hot swappable so the API at least ought to get that right. Alan From mboxrd@z Thu Jan 1 00:00:00 1970 From: One Thousand Gnomes Subject: Re: [PATCH v7 5/6] pci: Export find_pci_host_bridge() function. Date: Mon, 7 Apr 2014 15:38:50 +0100 Message-ID: <20140407153850.3c9ef3e5@alan.etchedpixels.co.uk> References: <1394811272-1547-1-git-send-email-Liviu.Dudau@arm.com> <1394811272-1547-6-git-send-email-Liviu.Dudau@arm.com> <20140404233948.GC15806@google.com> <20140407142045.GO17163@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140407142045.GO17163@e106497-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Liviu Dudau Cc: "devicetree@vger.kernel.org" , linaro-kernel , Catalin Marinas , Arnd Bergmann , linux-pci , Will Deacon , LKML , Grant Likely , Tanmay Inamdar , Benjamin Herrenschmidt , Bjorn Helgaas , LAKML List-Id: devicetree@vger.kernel.org > > If we *do* export it, I'd like it to have a more conventional name, e.g., > > something starting with "pci_". > > Understood. pci_find_host_bridge() ? pci_get_host_bridge() and take a reference IMHO ? If your primary bus is not PCI then your PCI "host" bridge could be hot swappable so the API at least ought to get that right. Alan