From: One Thousand Gnomes <gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
To: "Westerberg,
Mika" <mika.westerberg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "Du, Wenkai" <wenkai.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable
Date: Mon, 7 Apr 2014 15:42:52 +0100 [thread overview]
Message-ID: <20140407154252.6b8f0f7e@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <20140407090403.GG19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> I had to check BYT specs about that and I couldn't find if it does
> posted-writes.
Then I would assume it does unless you can find a hardware engineer to
sign a statement in blood to that effect 8)
> Actually the following patch should fix the problem as well. Just move the
> HW enable to happen last. That way we can make sure that there is a valid
> interrupt mask programmed before the controller is enabled.
This fixes the init case, it doesn't fix the question about returning
from the IRQ before the mask write takes effect and thus taking another
interrupt.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: "Westerberg, Mika" <mika.westerberg@intel.com>
Cc: "Du, Wenkai" <wenkai.du@intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable
Date: Mon, 7 Apr 2014 15:42:52 +0100 [thread overview]
Message-ID: <20140407154252.6b8f0f7e@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <20140407090403.GG19349@intel.com>
> I had to check BYT specs about that and I couldn't find if it does
> posted-writes.
Then I would assume it does unless you can find a hardware engineer to
sign a statement in blood to that effect 8)
> Actually the following patch should fix the problem as well. Just move the
> HW enable to happen last. That way we can make sure that there is a valid
> interrupt mask programmed before the controller is enabled.
This fixes the init case, it doesn't fix the question about returning
from the IRQ before the mask write takes effect and thus taking another
interrupt.
Alan
next prev parent reply other threads:[~2014-04-07 14:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:05 [PATCH] i2c-designware: Mask interrupts during i2c controller enable Du, Wenkai
[not found] ` <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-04 18:16 ` Westerberg, Mika
2014-04-04 18:16 ` Westerberg, Mika
[not found] ` <20140404181613.GB19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-04 18:20 ` Du, Wenkai
2014-04-04 18:20 ` Du, Wenkai
[not found] ` <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70F8B-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-04 18:42 ` Westerberg, Mika
2014-04-04 18:42 ` Westerberg, Mika
[not found] ` <20140404184232.GC19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-04 21:54 ` Du, Wenkai
2014-04-04 21:54 ` Du, Wenkai
[not found] ` <7286EAF50D3F4E4AADE7FEECEBF8B5A537A71351-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-05 6:13 ` Westerberg, Mika
2014-04-05 6:13 ` Westerberg, Mika
[not found] ` <20140405061316.GF19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-06 17:58 ` One Thousand Gnomes
2014-04-06 17:58 ` One Thousand Gnomes
[not found] ` <20140406185818.3aaca03d-mUKnrFFms3BCCTY1wZZT65JpZx93mCW/@public.gmane.org>
2014-04-07 9:04 ` Westerberg, Mika
2014-04-07 9:04 ` Westerberg, Mika
[not found] ` <20140407090403.GG19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-07 14:42 ` One Thousand Gnomes [this message]
2014-04-07 14:42 ` One Thousand Gnomes
2014-04-07 15:11 ` Westerberg, Mika
[not found] ` <20140407151107.GL19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-07 16:48 ` Du, Wenkai
2014-04-07 16:48 ` Du, Wenkai
2014-04-08 10:30 ` Westerberg, Mika
2014-04-09 23:45 ` Du, Wenkai
2014-04-10 9:08 ` Westerberg, Mika
[not found] ` <20140410090826.GW19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-10 23:06 ` Du, Wenkai
2014-04-10 23:06 ` Du, Wenkai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407154252.6b8f0f7e@alan.etchedpixels.co.uk \
--to=gnomes-qbu/x9rampvanceybjwyrvxrex20p6io@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wenkai.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.