All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/5] spi: ti_qspi: Add delay for successful bulk erase.
Date: Mon, 7 Apr 2014 13:21:28 -0400	[thread overview]
Message-ID: <20140407172128.GH23803@bill-the-cat> (raw)
In-Reply-To: <CAD6G_RQ6pOqi6UYLmTK74wmRWSjvJtVRjJH99roW6WcKAA5u=g@mail.gmail.com>

On Thu, Apr 03, 2014 at 08:45:42PM +0530, Jagan Teki wrote:
> On Thu, Apr 3, 2014 at 5:22 PM, Tom Rini <trini@ti.com> wrote:
> > From: "Poddar, Sourav" <sourav.poddar@ti.com>
> >
> > Bulk erase is not happening properly on dra7 due to erase timing constraints,
> > add a delay so that erase timing constraints are properly met.
> >
> > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> > Tested-by: Yebio Mesfin <ymesfin@ti.com>
> > ---
> >  drivers/spi/ti_qspi.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
> > index dfa5d0c..c5d2245 100644
> > --- a/drivers/spi/ti_qspi.c
> > +++ b/drivers/spi/ti_qspi.c
> > @@ -314,6 +314,9 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
> >                         qslave->cmd |= QSPI_RD_SNGL;
> >                         debug("rx cmd %08x dc %08x\n",
> >                               qslave->cmd, qslave->dc);
> > +                       #ifdef CONFIG_DRA7XX
> > +                               udelay(500);
> > +                       #endif
> >                         writel(qslave->cmd, &qslave->base->cmd);
> >                         status = readl(&qslave->base->status);
> >                         timeout = QSPI_TIMEOUT;
> 
> Can't we fix this? discussed the same in previous version thread as well.

Sorry, I kicked out v2 before checking my mbox again.  Sourav, do you
have some time to look at this again?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140407/7f8ecf13/attachment.pgp>

  reply	other threads:[~2014-04-07 17:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 11:52 [U-Boot] [PATCH v2 1/5] TI:omap5: Move CONFIG_ENV_SIZE to board config files Tom Rini
2014-04-03 11:52 ` [U-Boot] [PATCH v2 2/5] TI:armv7: Change Falcon Mode DT load address Tom Rini
2014-04-18 13:23   ` [U-Boot] [U-Boot, v2, " Tom Rini
2014-04-03 11:52 ` [U-Boot] [PATCH v2 3/5] spi: ti_qspi: Add delay for successful bulk erase Tom Rini
2014-04-03 15:15   ` Jagan Teki
2014-04-07 17:21     ` Tom Rini [this message]
2014-04-08  5:12       ` Sourav Poddar
2014-04-18 13:23   ` [U-Boot] [U-Boot, v2, " Tom Rini
2014-04-03 11:52 ` [U-Boot] [PATCH v2 4/5] SPL:SPI: Add Falcon Mode support Tom Rini
2014-04-18 13:23   ` [U-Boot] [U-Boot,v2,4/5] " Tom Rini
2014-04-03 11:52 ` [U-Boot] [PATCH v2 5/5] dra7xx_evm: Add QSPI_4 support, qspiboot build target Tom Rini
2014-04-18 13:23   ` [U-Boot] [U-Boot, v2, " Tom Rini
2014-04-18 13:23 ` [U-Boot] [U-Boot, v2, 1/5] TI:omap5: Move CONFIG_ENV_SIZE to board config files Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140407172128.GH23803@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.