From: Damien Lespiau <damien.lespiau@intel.com>
To: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip
Date: Mon, 7 Apr 2014 23:20:14 +0100 [thread overview]
Message-ID: <20140407222014.GL6407@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140407205917.GD18726@intel.com>
On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote:
> Cool. This explains the bad DERRMR values I was seeing in in error
> states. I'm honestly didn't check if we actually need an SRM for BDW
> still, but I'll assume you did check.
Just checked, the LRI command still mentions that we need the SRM after
writes to the display engine.
> I also think it's worth to make a intel_gen8_queue_flip, but since I
> don't touch this code much, I'll leave it to you to decide.
Don't have a strong opinion at all, so I'll leave it at that for now.
--
Damien
next prev parent reply other threads:[~2014-04-07 22:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 19:24 [PATCH 0/3] GEN8 SRM changes Damien Lespiau
2014-04-07 19:24 ` [PATCH 1/3] drm/i915: Protect the argument expansion in LRI and SRM macros Damien Lespiau
2014-04-07 20:47 ` Ben Widawsky
2014-04-09 12:57 ` Daniel Vetter
2014-04-07 19:24 ` [PATCH 2/3] drm/i915/bdw: Provide a gen8 version of SRM Damien Lespiau
2014-04-07 19:24 ` [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip Damien Lespiau
2014-04-07 20:59 ` Ben Widawsky
2014-04-07 22:20 ` Damien Lespiau [this message]
2014-04-08 6:24 ` Chris Wilson
2014-04-08 6:54 ` Damien Lespiau
2014-04-09 12:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407222014.GL6407@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.