From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables PATCH] src: rule: Fix list of set: Add a forgotten 'return'
Date: Tue, 8 Apr 2014 09:35:02 +0200 [thread overview]
Message-ID: <20140408073502.GA3700@localhost> (raw)
In-Reply-To: <bf9127aa386c8ca027215124fc1540f4f8ab9797.1396941336.git.anarey@gmail.com>
On Tue, Apr 08, 2014 at 09:19:27AM +0200, Ana Rey wrote:
> Add a return forgotten.
I prefer if you include in the patch description the important facts:
* This patch fixes a crash since this iterates over the temporary
context list a bit below on that code to handle table and chains
(that we don't have in this case).
* Something descriptive on how this happens, eg.
% nft list sets
Segmentation fault
Or even better:
% valgrind nft list sets
...
valgrind report goes here.
...
Please, also rework the title:
src: rule: Fix list of set: Add a forgotten 'return'
something much more simple like:
rule: fix crash in set listing
should be fine.
prev parent reply other threads:[~2014-04-08 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 7:19 [nftables PATCH] src: rule: Fix list of set: Add a forgotten 'return' Ana Rey
2014-04-08 7:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408073502.GA3700@localhost \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.