From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRpp-0002dP-9B for qemu-devel@nongnu.org; Tue, 08 Apr 2014 04:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXRph-0008Ab-UT for qemu-devel@nongnu.org; Tue, 08 Apr 2014 04:56:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRph-0008AW-Ll for qemu-devel@nongnu.org; Tue, 08 Apr 2014 04:56:41 -0400 Date: Tue, 8 Apr 2014 11:57:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20140408085719.GC4880@redhat.com> References: <1396608084-26986-1-git-send-email-tiwai@suse.de> <1396608084-26986-5-git-send-email-tiwai@suse.de> <1396858063.5001.49.camel@nilsson.home.kraxel.org> <20140407203851.GA18511@redhat.com> <1396938334.22660.27.camel@nilsson.home.kraxel.org> <20140408081124.GA4880@redhat.com> <1396946997.22660.36.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1396946997.22660.36.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Takashi Iwai , qemu-devel@nongnu.org, Anthony Liguori , Cole Robinson On Tue, Apr 08, 2014 at 10:49:57AM +0200, Gerd Hoffmann wrote: > On Di, 2014-04-08 at 11:11 +0300, Michael S. Tsirkin wrote: > > On Tue, Apr 08, 2014 at 08:25:34AM +0200, Gerd Hoffmann wrote: > > > On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote: > > > > On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote: > > > > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > > > > > I simply like it better, you don't? :) > > > > > > > > > > I still think we should make this simply depend on absolute/relative > > > > > pointer mode instead of asking the user to switch it manually. > > > > > > > > Hmm how do I set absolute/relative mode? > > > > > > Depends on the pointer input device being used. > > > > > > Start guest with "-device usb-tablet". Go to HMP. 'info mice' should > > > list the ps/2 mouse and the usb tablet. Using 'mouse_set' (or was it > > > set_mouse?) you can force one of the two devides being used. > > > > > > If you pick the tablet (should be active by default) absolute pointer > > > events are passed to the guest, and qemu works in absolute mode (i.e. > > > sdl doesn't do pointer grabs). > > > > > > If you pick the mouse relative mouse events are passed to the guest, and > > > qemu works in relative mode (pointer grab is pretty much required to > > > work with the guest). > > > > > > cheers, > > > Gerd > > > > > > > I have to say grab on click is easier to understand - more predictable. > > Not requesting that it's made the default, but an option would be nice. > > Well, usually you'll never ever pick the pointer device manually, this > is mainly meant for testing things or checkout what the behavior is. > > Another topic is how to actually activate the grab (when in relative > mode where it is needed). You surely don't want grab the pointer on > hover as simply crossing the guest window will activate it. Sounds kind of useful. Why isn't it? > Grab-(+ungrab)-by-hotkey and grab-on-click is what SDL, virt-viewer & > friends are doing today. I think gtk should simply do the same for > consistency, and I don't see a need for a config option. > > cheers, > Gerd Aha. It's lack of grab on click that makes me unhappy. So how about doing this for 2.0? Drop grab on hover make grab on click the default. -- MST