From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43181)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WXXcv-0001Mc-Nh
	for qemu-devel@nongnu.org; Tue, 08 Apr 2014 11:07:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WXXcq-0003QH-Fp
	for qemu-devel@nongnu.org; Tue, 08 Apr 2014 11:07:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9364)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WXXcq-0003Q2-7d
	for qemu-devel@nongnu.org; Tue, 08 Apr 2014 11:07:48 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s38F7lYl027933
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 8 Apr 2014 11:07:47 -0400
Date: Tue, 8 Apr 2014 17:07:45 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140408150745.GC6262@noname.str.redhat.com>
References: <1396961442-24046-1-git-send-email-mreitz@redhat.com>
	<1396961442-24046-3-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1396961442-24046-3-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/6] block-commit: speed is an optional
	parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 08.04.2014 um 14:50 hat Max Reitz geschrieben:
> As speed is an optional parameter for the QMP block-commit command, it
> should be set to 0 if not given (as it is undefined if has_speed is
> false), that is, the speed should not be limited.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Should this be Cc: qemu-stable@nongnu.org?

Kevin

>  blockdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/blockdev.c b/blockdev.c
> index b988cc5..9d7bd04 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1876,6 +1876,9 @@ void qmp_block_commit(const char *device,
>       */
>      BlockdevOnError on_error = BLOCKDEV_ON_ERROR_REPORT;
>  
> +    if (!has_speed) {
> +        speed = 0;
> +    }
>      if (!has_granularity) {
>          granularity = 0;
>      }
> -- 
> 1.9.1
>