From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mtosatti@redhat.com, aarcange@redhat.com, mgorman@suse.de,
akpm@linux-foundation.org, andi@firstfloor.org, davidlohr@hp.com,
rientjes@google.com, isimatu.yasuaki@jp.fujitsu.com,
yinghai@kernel.org, riel@redhat.com, n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit
Date: Tue, 8 Apr 2014 23:51:26 +0300 [thread overview]
Message-ID: <20140408205126.GA2778@node.dhcp.inet.fi> (raw)
In-Reply-To: <1396983740-26047-4-git-send-email-lcapitulino@redhat.com>
On Tue, Apr 08, 2014 at 03:02:18PM -0400, Luiz Capitulino wrote:
> Hugepages pages never get the PG_reserved bit set, so don't clear it. But
> add a warning just in case.
I don't think WARN_ON() is needed. PG_reserved will be catched by
free_pages_check().
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-04-08 20:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 19:02 [PATCH v2 0/5] hugetlb: add support gigantic page allocation at runtime Luiz Capitulino
2014-04-08 19:02 ` Luiz Capitulino
2014-04-08 19:02 ` [PATCH 1/5] hugetlb: prep_compound_gigantic_page(): drop __init marker Luiz Capitulino
2014-04-08 19:02 ` Luiz Capitulino
2014-04-08 19:51 ` Naoya Horiguchi
[not found] ` <1396986711-o0m2kq1v@n-horiguchi@ah.jp.nec.com>
2014-04-08 20:25 ` Luiz Capitulino
2014-04-08 20:25 ` Luiz Capitulino
2014-04-08 19:02 ` [PATCH 2/5] hugetlb: add hstate_is_gigantic() Luiz Capitulino
2014-04-08 19:02 ` Luiz Capitulino
2014-04-08 19:02 ` [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit Luiz Capitulino
2014-04-08 19:02 ` Luiz Capitulino
2014-04-08 20:51 ` Kirill A. Shutemov [this message]
2014-04-08 21:11 ` Luiz Capitulino
2014-04-08 21:11 ` Luiz Capitulino
2014-04-08 19:02 ` [PATCH 4/5] hugetlb: move helpers up in the file Luiz Capitulino
2014-04-08 19:02 ` Luiz Capitulino
2014-04-08 19:02 ` [PATCH 5/5] hugetlb: add support for gigantic page allocation at runtime Luiz Capitulino
2014-04-08 19:02 ` Luiz Capitulino
2014-04-08 20:38 ` Naoya Horiguchi
2014-04-09 0:42 ` Yasuaki Ishimatsu
2014-04-09 0:42 ` Yasuaki Ishimatsu
2014-04-09 17:56 ` Luiz Capitulino
2014-04-09 17:56 ` Luiz Capitulino
2014-04-10 4:39 ` Yasuaki Ishimatsu
2014-04-10 4:39 ` Yasuaki Ishimatsu
-- strict thread matches above, loose matches on Subject: below --
2014-04-10 17:58 [PATCH v3 0/5] hugetlb: add support " Luiz Capitulino
2014-04-10 17:58 ` [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit Luiz Capitulino
2014-04-10 17:58 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408205126.GA2778@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davidlohr@hp.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mtosatti@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.