All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Luis Ortega <luiorpe1@gmail.com>
Cc: lisa@xenapiadmin.com, daeseok.youn@gmail.com,
	rashika.kheria@gmail.com, dan.carpenter@oracle.com,
	veeableful@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: Qos: fixed braces' coding style
Date: Tue, 8 Apr 2014 14:11:03 -0700	[thread overview]
Message-ID: <20140408211103.GA17219@kroah.com> (raw)
In-Reply-To: <1396998065-4448-1-git-send-email-luiorpe1@gmail.com>

On Wed, Apr 09, 2014 at 01:01:05AM +0200, Luis Ortega wrote:
> Fixed badly placed and unnecessary braces.
> 
> PS: Performed as task 10 of the Eudyptula Challenge.
> 
> Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
> ---
>  drivers/staging/bcm/Qos.c | 174 +++++++++++++---------------------------------
>  1 file changed, 48 insertions(+), 126 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
> index 4f31583..4b9ce26 100644
> --- a/drivers/staging/bcm/Qos.c
> +++ b/drivers/staging/bcm/Qos.c
> @@ -33,14 +33,11 @@ static bool MatchSrcIpAddress(struct bcm_classifier_rule *pstClassifierRule, ULO
>  	ulSrcIP = ntohl(ulSrcIP);
>  	if (0 == pstClassifierRule->ucIPSourceAddressLength)
>  		return TRUE;
> -	for (ucLoopIndex = 0; ucLoopIndex < (pstClassifierRule->ucIPSourceAddressLength); ucLoopIndex++)
> -	{
> +	for (ucLoopIndex = 0; ucLoopIndex < (pstClassifierRule->ucIPSourceAddressLength); ucLoopIndex++) 	{

Why the <TAB> before the '{' character?

thanks,

greg k-h

  reply	other threads:[~2014-04-08 21:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 23:01 [PATCH] Staging: bcm: Qos: fixed braces' coding style Luis Ortega
2014-04-08 21:11 ` Greg KH [this message]
2014-04-09  8:28   ` Luis Ortega
2014-04-09  8:54     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408211103.GA17219@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daeseok.youn@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    --cc=luiorpe1@gmail.com \
    --cc=rashika.kheria@gmail.com \
    --cc=veeableful@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.