Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

[Tony Lindgren <tony@atomide.com>]

* Aaro Koskinen <aaro.koskinen@iki.fi> [140408 14:48]:
> Hi,
> 
> On Tue, Apr 08, 2014 at 10:51:18PM +0200, Sebastian Reichel wrote:
> > Do not try to initialize display for DT boot, since omapdss
> > is now initialized via Device Tree. Without this patch the
> > display subsystem does not properly come up.
> > 
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > ---
> > Hi,
> > 
> > This patch should be added to 3.15-rc to make display initialization via DT
> > possible. Sorry for not noticing earlier, that this was missing in Tomi's
> > patchset.
> > 
> > -- Sebastian
> > ---
> >  arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
> > index 43a90c8..9cfebc5 100644
> > --- a/arch/arm/mach-omap2/board-rx51-video.c
> > +++ b/arch/arm/mach-omap2/board-rx51-video.c
> > @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
> >  
> >  static int __init rx51_video_init(void)
> >  {
> > -	if (!machine_is_nokia_rx51() && !of_machine_is_compatible("nokia,omap3-n900"))
> > +	if (!machine_is_nokia_rx51())
> >  		return 0;
> 
> Shouldn't we delete the whole file, since non-DT boot is
> not anymore supported?

Legacy support is still there for omap3 until the DSS displays are
converted.

Regards,

Tony