From: Serge Hallyn <serge.hallyn@ubuntu.com>
To: qemu-devel@nongnu.org
Cc: Michael Tokarev <mjt@tls.msk.ru>,
1303926@bugs.launchpad.net,
Mario Smarduch <m.smarduch@samsung.com>
Subject: [Qemu-devel] [PATCH 1/1] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl
Date: Tue, 8 Apr 2014 22:21:06 -0500 [thread overview]
Message-ID: <20140409032106.GA5163@sergelap> (raw)
ENOENT (iiuc) means the kernel has an empty dirty bitmap for this
slot. Don't abort in that case. This appears to solve the bug
reported at
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1303926
which first showed up with commit b533f658a98325d: fix return check for
KVM_GET_DIRTY_LOG ioctl
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
---
kvm-all.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kvm-all.c b/kvm-all.c
index 82a9119..7b7ea8d 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -441,10 +441,13 @@ static int kvm_physical_sync_dirty_bitmap(MemoryRegionSection *section)
d.slot = mem->slot;
- if (kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
+ ret = kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d);
+ if (ret < 0 && ret != -ENOENT) {
DPRINTF("ioctl failed %d\n", errno);
ret = -1;
break;
+ } else if (ret < 0) {
+ ret = 0;
}
kvm_get_dirty_pages_log_range(section, d.dirty_bitmap);
--
1.9.1
next reply other threads:[~2014-04-09 3:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 3:21 Serge Hallyn [this message]
2014-04-09 3:31 ` [Qemu-devel] [PATCH 1/1] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl Serge E. Hallyn
2014-04-10 16:30 ` Michael Tokarev
2014-04-10 18:47 ` Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409032106.GA5163@sergelap \
--to=serge.hallyn@ubuntu.com \
--cc=1303926@bugs.launchpad.net \
--cc=m.smarduch@samsung.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.