From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v3 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform Date: Wed, 9 Apr 2014 15:51:55 +0800 Message-ID: <20140409075154.GA12559@MrMyself> References: <08ba57a2fdce1a404a6bcb61e21e25509fcd6b30.1396605772.git.Guangyu.Chen@freescale.com> <20140409075812.GC28420@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20140409075812.GC28420@dragon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Shawn Guo Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, pawel.moll@arm.com, linux-doc@vger.kernel.org, broonie@kernel.org, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, timur@tabi.org, Li.Xiubo@freescale.com, rob@landley.net, galak@codeaurora.org, linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org T24gV2VkLCBBcHIgMDksIDIwMTQgYXQgMDM6NTg6MTVQTSArMDgwMCwgU2hhd24gR3VvIHdyb3Rl Ogo+IE9uIEZyaSwgQXByIDA0LCAyMDE0IGF0IDA2OjA4OjEzUE0gKzA4MDAsIE5pY29saW4gQ2hl biB3cm90ZToKPiA+IFNpbmNlIHdlIGFkZGVkIGZvdXJzIGNsb2NrIHRvIHRoZSBEVCBiaW5kaW5n LCB3ZSBzaG91bGQgdXBkYXRlIHRoZSBjdXJyZW50Cj4gPiBTQUkgZHRzL2R0c2kgc28gYXMgbm90 IHRvIGJyZWFrIHRoZWlyIGZ1bmN0aW9ucy4KPiAKPiBJZiBzbywgc2hvdWxkbid0IHRoZSBjaGFu Z2UgYmUgaW4gdGhlIHNhbWUgcGF0Y2ggYXMgZHJpdmVyIGNoYW5nZT8KCk9rYXkuLkknZCBsaWtl IHRvIG1lcmdlIHRoZW0gaW50byBvbmUgcGF0Y2guCgpUaGFuayB5b3UsCk5pY29saW4KCj4gCj4g U2hhd24KPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTmljb2xpbiBDaGVuIDxHdWFuZ3l1LkNo ZW5AZnJlZXNjYWxlLmNvbT4KPiA+IFRlc3RlZC1ieTogWGl1Ym8gTGkgPExpLlhpdWJvQGZyZWVz Y2FsZS5jb20+Cj4gPiAtLS0KPiA+ICBhcmNoL2FybS9ib290L2R0cy92ZjYxMC5kdHNpIHwgNiAr KysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvdmY2MTAuZHRzaSBiL2Fy Y2gvYXJtL2Jvb3QvZHRzL3ZmNjEwLmR0c2kKPiA+IGluZGV4IGQzMWNlMWIuLjlmZDAwMDcgMTAw NjQ0Cj4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy92ZjYxMC5kdHNpCj4gPiArKysgYi9hcmNo L2FybS9ib290L2R0cy92ZjYxMC5kdHNpCj4gPiBAQCAtMTM5LDggKzEzOSwxMCBAQAo+ID4gIAkJ CQljb21wYXRpYmxlID0gImZzbCx2ZjYxMC1zYWkiOwo+ID4gIAkJCQlyZWcgPSA8MHg0MDAzMTAw MCAweDEwMDA+Owo+ID4gIAkJCQlpbnRlcnJ1cHRzID0gPDAgODYgMHgwND47Cj4gPiAtCQkJCWNs b2NrcyA9IDwmY2xrcyBWRjYxMF9DTEtfU0FJMj47Cj4gPiAtCQkJCWNsb2NrLW5hbWVzID0gInNh aSI7Cj4gPiArCQkJCWNsb2NrcyA9IDwmY2xrcyBWRjYxMF9DTEtfU0FJMj4sCj4gPiArCQkJCSAg ICAgICA8JmNsa3MgVkY2MTBfQ0xLX1NBSTI+LAo+ID4gKwkJCQkgICAgICAgPCZjbGtzIDA+LCA8 JmNsa3MgMD47Cj4gPiArCQkJCWNsb2NrLW5hbWVzID0gImJ1cyIsICJtY2xrMSIsICJtY2xrMiIs ICJtY2xrMyI7Cj4gPiAgCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gPiAgCQkJfTsKPiA+ICAK PiA+IC0tIAo+ID4gMS44LjQKPiA+IAo+ID4gCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBj LWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9s aW51eHBwYy1kZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe003.messaging.microsoft.com [65.55.88.13]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6F0EF140080 for ; Wed, 9 Apr 2014 18:02:56 +1000 (EST) Date: Wed, 9 Apr 2014 15:51:55 +0800 From: Nicolin Chen To: Shawn Guo Subject: Re: [PATCH v3 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform Message-ID: <20140409075154.GA12559@MrMyself> References: <08ba57a2fdce1a404a6bcb61e21e25509fcd6b30.1396605772.git.Guangyu.Chen@freescale.com> <20140409075812.GC28420@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20140409075812.GC28420@dragon> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, pawel.moll@arm.com, linux-doc@vger.kernel.org, broonie@kernel.org, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, timur@tabi.org, Li.Xiubo@freescale.com, rob@landley.net, galak@codeaurora.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Apr 09, 2014 at 03:58:15PM +0800, Shawn Guo wrote: > On Fri, Apr 04, 2014 at 06:08:13PM +0800, Nicolin Chen wrote: > > Since we added fours clock to the DT binding, we should update the current > > SAI dts/dtsi so as not to break their functions. > > If so, shouldn't the change be in the same patch as driver change? Okay..I'd like to merge them into one patch. Thank you, Nicolin > > Shawn > > > > > Signed-off-by: Nicolin Chen > > Tested-by: Xiubo Li > > --- > > arch/arm/boot/dts/vf610.dtsi | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > > index d31ce1b..9fd0007 100644 > > --- a/arch/arm/boot/dts/vf610.dtsi > > +++ b/arch/arm/boot/dts/vf610.dtsi > > @@ -139,8 +139,10 @@ > > compatible = "fsl,vf610-sai"; > > reg = <0x40031000 0x1000>; > > interrupts = <0 86 0x04>; > > - clocks = <&clks VF610_CLK_SAI2>; > > - clock-names = "sai"; > > + clocks = <&clks VF610_CLK_SAI2>, > > + <&clks VF610_CLK_SAI2>, > > + <&clks 0>, <&clks 0>; > > + clock-names = "bus", "mclk1", "mclk2", "mclk3"; > > status = "disabled"; > > }; > > > > -- > > 1.8.4 > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932690AbaDIISB (ORCPT ); Wed, 9 Apr 2014 04:18:01 -0400 Received: from tx2ehsobe008.messaging.microsoft.com ([65.55.88.32]:46770 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758037AbaDIIR5 (ORCPT ); Wed, 9 Apr 2014 04:17:57 -0400 X-Greylist: delayed 904 seconds by postgrey-1.27 at vger.kernel.org; Wed, 09 Apr 2014 04:17:57 EDT X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(z579ehz98dI1432Izz1f42h2148h1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6h208chzz1de098h8275bh1de097hz2dh2a8h839h944hd25hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1b2fh2222h224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h209eh2216h22d0h2336h2438h2461h2487h24d7h2516h2545h255eh25cch25f6h2605h262fh268bh26d3h1155h) Date: Wed, 9 Apr 2014 15:51:55 +0800 From: Nicolin Chen To: Shawn Guo CC: , , , , , , , , , , , , , Subject: Re: [PATCH v3 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform Message-ID: <20140409075154.GA12559@MrMyself> References: <08ba57a2fdce1a404a6bcb61e21e25509fcd6b30.1396605772.git.Guangyu.Chen@freescale.com> <20140409075812.GC28420@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20140409075812.GC28420@dragon> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-FOPE-CONNECTOR: Id%0$Dn%FREESCALE.MAIL.ONMICROSOFT.COM$RO%1$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 09, 2014 at 03:58:15PM +0800, Shawn Guo wrote: > On Fri, Apr 04, 2014 at 06:08:13PM +0800, Nicolin Chen wrote: > > Since we added fours clock to the DT binding, we should update the current > > SAI dts/dtsi so as not to break their functions. > > If so, shouldn't the change be in the same patch as driver change? Okay..I'd like to merge them into one patch. Thank you, Nicolin > > Shawn > > > > > Signed-off-by: Nicolin Chen > > Tested-by: Xiubo Li > > --- > > arch/arm/boot/dts/vf610.dtsi | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > > index d31ce1b..9fd0007 100644 > > --- a/arch/arm/boot/dts/vf610.dtsi > > +++ b/arch/arm/boot/dts/vf610.dtsi > > @@ -139,8 +139,10 @@ > > compatible = "fsl,vf610-sai"; > > reg = <0x40031000 0x1000>; > > interrupts = <0 86 0x04>; > > - clocks = <&clks VF610_CLK_SAI2>; > > - clock-names = "sai"; > > + clocks = <&clks VF610_CLK_SAI2>, > > + <&clks VF610_CLK_SAI2>, > > + <&clks 0>, <&clks 0>; > > + clock-names = "bus", "mclk1", "mclk2", "mclk3"; > > status = "disabled"; > > }; > > > > -- > > 1.8.4 > > > > >