All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, sachin.kamat@linaro.org,
	devel@driverdev.osuosl.org, grygorii.strashko@ti.com,
	lisa@xenapiadmin.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()
Date: Wed, 9 Apr 2014 14:39:04 +0300	[thread overview]
Message-ID: <20140409113904.GE4912@mwanda> (raw)
In-Reply-To: <2039876.xlVvlD6iFL@daeseok-laptop.cloud.net>

On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
> 
> A string of goto_buf has a number followed by x or y.
> e.g. "3x" means move 3 lines down.
> The kstrtol() returns an error(-EINVAL) with this string so
> go_pos has unsigned a value of that error.
> And also "*cp" has not expected value.
> 

Good catch.  This was introduced when we changed the simple_strtoul() to
kstrtol().

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

Did you find this bug by testing or through reading the code?

regards,
dan carpenter


  reply	other threads:[~2014-04-09 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 10:45 [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto() Daeseok Youn
2014-04-09 11:39 ` Dan Carpenter [this message]
2014-04-09 13:53   ` DaeSeok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140409113904.GE4912@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=daeseok.youn@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.