From: chrubis@suse.cz
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] lib/tst_uid_gid.c: fix checking return value errors about getpwuid_r/getgrgid_r
Date: Wed, 9 Apr 2014 15:23:20 +0200 [thread overview]
Message-ID: <20140409132320.GC5712@rei> (raw)
In-Reply-To: <53454939.2030704@oracle.com>
Hi!
> >> Thank you very-very much.
> >>
> >> It's not bad that we included GET_UNUSED* in LTP. Maybe somebody someday
> >> will need it for their purposes... :)
> >>
> >
> > I'm personaly for removing any unused code because
> >
> > * you may readd it later when needed because it's in the git history
> > * there is a price for mantaining each line of code we have
> > * and any unused code tend to break sooner or later
> >
> > So I would rather see it removed now and I promise to readd it when we
> > found a purpose for it.
> >
> No problem.
>
> Just to make it clear. Are you going to remove it by yourself? Or do you
> want me to prepare a patch for this?
>
> Actually, I would like the first option :)
OK, I will remove them.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-04-09 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 2:10 [LTP] [PATCH] lib/tst_uid_gid.c: fix checking return value errors about getpwuid_r/getgrgid_r Zeng Linggang
2014-02-20 7:53 ` Stanislav Kholmanskikh
2014-03-06 11:34 ` Zeng Linggang
2014-03-06 12:36 ` Stanislav Kholmanskikh
2014-03-10 8:13 ` Zeng Linggang
2014-03-13 8:33 ` Zeng Linggang
[not found] ` <1396944482.2100.1.camel@G08JYZSD130126>
2014-04-08 11:19 ` chrubis
[not found] ` <5344069B.8010101@oracle.com>
2014-04-08 14:49 ` chrubis
2014-04-08 15:52 ` chrubis
[not found] ` <5344E5C8.3070306@oracle.com>
2014-04-09 13:08 ` chrubis
[not found] ` <53454939.2030704@oracle.com>
2014-04-09 13:23 ` chrubis [this message]
2014-04-09 14:39 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409132320.GC5712@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.