From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vitaly Osipov <vitaly.osipov@gmail.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: omap24xx: fix up some checkpatch.pl issues
Date: Wed, 9 Apr 2014 09:21:58 -0700 [thread overview]
Message-ID: <20140409162158.GA15832@kroah.com> (raw)
In-Reply-To: <20140409132511.GA7873@witts-MacBook-Pro.local>
On Wed, Apr 09, 2014 at 11:25:18PM +1000, Vitaly Osipov wrote:
> Fixes the following issues:
>
> tcm825x.c:
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> tcm825x.h:
>
> ERROR: Macros with complex values should be enclosed in parenthesis
Please only do one type of thing per patch. So this should be a series
of 2 patches, one for the macro "error", and one for the printk fixes.
Can you please redo these and resend them?
thanks,
greg k-h
next parent reply other threads:[~2014-04-09 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140409132511.GA7873@witts-MacBook-Pro.local>
2014-04-09 16:21 ` Greg Kroah-Hartman [this message]
2014-04-09 14:30 [PATCH] staging: media: omap24xx: fix up some checkpatch.pl issues Vitaly Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409162158.GA15832@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.