From: Greg KH <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
kbuild-all@01.org, Jes Sorensen <Jes.Sorensen@redhat.com>
Subject: Re: [PATCH] staging: r8723au: Fix build warnings
Date: Wed, 9 Apr 2014 09:37:35 -0700 [thread overview]
Message-ID: <20140409163735.GC16346@kroah.com> (raw)
In-Reply-To: <1397055920-11654-1-git-send-email-Larry.Finger@lwfinger.net>
On Wed, Apr 09, 2014 at 10:05:20AM -0500, Larry Finger wrote:
> The kbuild test robot reports the following:
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 75ff24fa52f0cc512ceee4c377632b91a3a80811
> commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au: Turn on build of new driver
> date: 4 days ago
> config: make ARCH=avr32 allyesconfig
>
> All warnings:
>
> >> drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: 'rtw_set_roaming' declared inline after being called
> drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: previous declaration of 'rtw_set_roaming' was here
> >> drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: 'rtw_to_roaming' declared inline after being called
> drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: previous declaration of 'rtw_to_roaming' was here
> --
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c: In function 'Hal_EEValueCheck':
> >> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2277: warning: comparison is always true due to limited range of data type
>
> The first two warnings are fixed by making the two prototypes be "inline" to match
> the actual routine. The third warning comes from testing that a u8 quantity is positive.
If the functions are inline, why are they referenced in a .h file at
all?
prev parent reply other threads:[~2014-04-09 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:05 [PATCH] staging: r8723au: Fix build warnings Larry Finger
2014-04-09 16:15 ` Joe Perches
2014-04-09 16:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409163735.GC16346@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.