From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anthony DeStefano <adx@fastmail.fm>
Cc: Antti Palosaari <crope@iki.fi>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rtl2832_sdr: fixup checkpatch/style issues
Date: Wed, 9 Apr 2014 18:47:06 -0700 [thread overview]
Message-ID: <20140410014706.GA11347@kroah.com> (raw)
In-Reply-To: <20140410000722.GA64332@pluto-arch.home>
On Wed, Apr 09, 2014 at 08:07:28PM -0400, Anthony DeStefano wrote:
> rtl2832_sdr.c: fixup checkpatch issues about long lines
>
> Signed-off-by: Anthony DeStefano <adx@fastmail.fm>
> ---
> drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c b/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c
> index 104ee8a..0e6c6fa 100644
> --- a/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c
> +++ b/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c
> @@ -935,7 +935,9 @@ static int rtl2832_sdr_set_tuner_freq(struct rtl2832_sdr_state *s)
> /*
> * bandwidth (Hz)
> */
> - bandwidth_auto = v4l2_ctrl_find(&s->hdl, V4L2_CID_RF_TUNER_BANDWIDTH_AUTO);
> + bandwidth_auto = v4l2_ctrl_find(&s->hdl,
> + V4L2_CID_RF_TUNER_BANDWIDTH_AUTO);
Please line stuff up under the (, so for this line it would be:
bandwidth_auto = v4l2_ctrl_find(&s->hdl,
V4L2_CID_RF_TUNER_BANDWIDTH_AUTO);
Please fix the rest of these all up.
greg k-h
prev parent reply other threads:[~2014-04-10 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 0:07 [PATCH] staging: rtl2832_sdr: fixup checkpatch/style issues Anthony DeStefano
2014-04-10 1:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410014706.GA11347@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adx@fastmail.fm \
--cc=crope@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.