From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WY4Wf-0006FD-IX for qemu-devel@nongnu.org; Wed, 09 Apr 2014 22:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WY4WZ-00063U-D8 for qemu-devel@nongnu.org; Wed, 09 Apr 2014 22:15:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WY4WZ-00061V-1q for qemu-devel@nongnu.org; Wed, 09 Apr 2014 22:15:31 -0400 Date: Thu, 10 Apr 2014 10:15:35 +0800 From: Fam Zheng Message-ID: <20140410021535.GC2855@T430.nay.redhat.com> References: <1394436370-8908-1-git-send-email-famz@redhat.com> <1394436370-8908-13-git-send-email-famz@redhat.com> <53431491.7010407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53431491.7010407@redhat.com> Subject: Re: [Qemu-devel] [PATCH v17 12/14] block: Add blockdev-backup to transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, benoit.canet@irqsave.net, rjones@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, ptoscano@redhat.com On Mon, 04/07 15:11, Eric Blake wrote: > On 03/10/2014 01:26 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > > qapi-schema.json | 1 + > > 2 files changed, 49 insertions(+) > > > > > +++ b/qapi-schema.json > > @@ -1972,6 +1972,7 @@ > > 'data': { > > 'blockdev-snapshot-sync': 'BlockdevSnapshot', > > 'drive-backup': 'DriveBackup', > > + 'blockdev-backup': 'BlockdevBackup', > > 'abort': 'Abort', > > 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal' > > } } > > It might be nice to mention that the union was expanded in 2.1; > something like: > > # A discriminated record of operations that can be performed with > # @transaction. > # > # Since 1.1, blockdev-backup since 2.1 > ## > { 'union': 'TransactionAction', > > Of course, this is a pre-existing problem, as we've added other actions > since 1.1 (blockdev-snapshot-internal-sync in 1.7, for example), so it > could be justified as a separate patch. But it can't hurt to start > being more thorough in our docs. > OK, I'll add this to comment. Thanks, Fam