All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	linux-crypto@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net,
	Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH 2/2] crypto: bfin_crc: avoid get physical address of coherence memory by dma_map_single
Date: Thu, 10 Apr 2014 11:02:51 +0200	[thread overview]
Message-ID: <201404101102.51947.marex@denx.de> (raw)
In-Reply-To: <1397119259-20638-2-git-send-email-sonic.adi@gmail.com>

On Thursday, April 10, 2014 at 10:40:59 AM, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> - The 4-byte sg_mid_buf is located in the middle of the coherence memory
> sg_cpu. Don't call dma_map_single to get its physical address. Get the its
> base physical address from the physical address of sg_cpu instead.
> - Should set up the dma descriptor data after the 4-byte sg_mid_buf is
> filled in completely from next sg buffer.
> - memory copy from sg buffer should be done via virtual address.
> - Remove unused reference to blackfin header
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>

I don't see any obvious problems,

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

  reply	other threads:[~2014-04-10  9:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  8:40 [PATCH 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm Sonic Zhang
2014-04-10  8:40 ` [PATCH 2/2] crypto: bfin_crc: avoid get physical address of coherence memory by dma_map_single Sonic Zhang
2014-04-10  9:02   ` Marek Vasut [this message]
2014-04-14  4:41     ` Sonic Zhang
2014-04-10  8:59 ` [PATCH 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm Marek Vasut
2014-04-10  9:51   ` Sonic Zhang
2014-04-10 12:33     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201404101102.51947.marex@denx.de \
    --to=marex@denx.de \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=sonic.adi@gmail.com \
    --cc=sonic.zhang@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.