From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Richard W.M. Jones" Subject: Re: Making discard/fstrim reliable Date: Thu, 10 Apr 2014 16:05:46 +0100 Message-ID: <20140410150546.GQ1302@redhat.com> References: <20140326204708.GA29191@redhat.com> <20140402185911.GO1302@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, pbonzini@redhat.com, =?utf-8?B?THVrw6HFoQ==?= Czerner To: Jeff Moyer Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbaDJPFs (ORCPT ); Thu, 10 Apr 2014 11:05:48 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3AF5l71006370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Apr 2014 11:05:47 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Just to finish off this subject. It was (kind of) a bug in the test suite: The test suite assumed that fstrim would trim the journal as well as the file content. I adjusted the test so it only measures the trimming of the file content, not any other metadata on the disk, and now the test works reliably. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org