From: Willy Tarreau <w@1wt.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
ezequiel.garcia@free-electrons.com, netdev@vger.kernel.org,
thomas.petazzoni@free-electrons.com,
gregory.clement@free-electrons.com, simon.guinot@sequanux.org,
tawfik@marvell.com, alior@marvell.com
Subject: Re: [PATCH 0/3] mvneta: software TSO implementation
Date: Fri, 11 Apr 2014 07:48:47 +0200 [thread overview]
Message-ID: <20140411054847.GE30855@1wt.eu> (raw)
In-Reply-To: <1397178150.16584.53.camel@edumazet-glaptop2.roam.corp.google.com>
On Thu, Apr 10, 2014 at 06:02:30PM -0700, Eric Dumazet wrote:
> On Thu, 2014-04-10 at 20:51 -0400, David Miller wrote:
> > This is not really driver specific code.
> >
> > Please create an appropriate abstraction, and put this code in a
> > common place so that any driver can do this.
> >
> > Thanks.
>
> Note a prior implementation existed in
>
> drivers/net/ethernet/tile/tilegx.c
>
> Note sure how it can be properly factorized, but worth trying .
I also tried to find how to do this for mv643xx_eth a few years ago
based on other drivers (eg: tilegx) and failed to find anything
common. At this level, we're really playing with the NIC's descriptors,
and many of them have different capabilities (eg: HW checksums for all
frames, VLAN or none, etc...). I don't really see how this could be
factorized, and since many NICs do support TSO, I'm not convinced by
the effort.
Willy
next prev parent reply other threads:[~2014-04-11 5:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 22:57 [PATCH 0/3] mvneta: software TSO implementation Ezequiel Garcia
2014-04-10 22:58 ` [PATCH 1/3] net: mvneta: Factorize feature setting Ezequiel Garcia
2014-04-10 22:58 ` [PATCH 2/3] net: mvneta: Clean mvneta_tx() sk_buff handling Ezequiel Garcia
2014-04-10 22:58 ` [PATCH 3/3] net: mvneta: Introduce a software TSO implementation Ezequiel Garcia
2014-04-10 23:16 ` Eric Dumazet
2014-05-05 14:47 ` Ezequiel Garcia
2014-05-07 6:04 ` Willy Tarreau
2014-05-21 2:11 ` Ben Hutchings
2014-05-22 17:47 ` Ezequiel Garcia
2014-04-11 0:51 ` [PATCH 0/3] mvneta: " David Miller
2014-04-11 1:02 ` Eric Dumazet
2014-04-11 5:48 ` Willy Tarreau [this message]
2014-04-11 6:20 ` David Miller
2014-04-11 6:30 ` Willy Tarreau
2014-04-11 16:58 ` David Miller
2014-04-11 19:08 ` Ezequiel Garcia
2014-04-11 19:43 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411054847.GE30855@1wt.eu \
--to=w@1wt.eu \
--cc=alior@marvell.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=simon.guinot@sequanux.org \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.