From mboxrd@z Thu Jan 1 00:00:00 1970 From: jszhang@marvell.com (Jisheng Zhang) Date: Fri, 11 Apr 2014 14:33:18 +0800 Subject: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation In-Reply-To: <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> Message-ID: <20140411143318.67e55a17@xhacker> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 10 Apr 2014 06:07:53 -0700 Antoine T?nart wrote: > Signed-off-by: Antoine T?nart > --- > .../bindings/pinctrl/marvell,berlin-pinctrl.txt | 43 > ++++++++++++++++++++++ 1 file changed, 43 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt > > diff --git > a/Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt new > file mode 100644 index 000000000000..e21538a37734 --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt > @@ -0,0 +1,43 @@ > +* Pinctrl driver for the Marvell Berlin SoCs > + > +The pins controlled by the Marvell Berlin controller are organized in > groups. +Configuration is done by group, so no actual pin information is > needed. + > +Required properties: > +- compatible: "marvell-berlin2cd-pinctrl", > + "marvell-berlin2-pinctrl", > + "marvell-berlin2q-pinctrl" > +- reg: registers physical addresses and lengths of the pin controller. > +- reg-names: name of the register regions. > + > +Please refer to pinctrl-bindings.txt in this directory for details of the > +common pinctrl bindings used by client devices. > + > +A pinctrl should contains subnodes representing the pinctrl pin group > +configurations, one per group. Each subnode has the group name and the > muxing +function used. > + > +Required subnode-properties: > +- berlin,group: a string describing the group's name. > +- berlin,function: the function used to mux the group. Would it be better to s/function/mode? Because in mrvl internal technology discussion and docs, we usually say "set pinmux Gy as mode z". Thanks, Jisheng From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation Date: Fri, 11 Apr 2014 14:33:18 +0800 Message-ID: <20140411143318.67e55a17@xhacker> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Antoine =?UTF-8?B?VMOpbmFydA==?= Cc: Jimmy Xu , "devicetree@vger.kernel.org" , "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "alexandre.belloni@free-electrons.com" , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" List-Id: devicetree@vger.kernel.org T24gVGh1LCAxMCBBcHIgMjAxNCAwNjowNzo1MyAtMDcwMApBbnRvaW5lIFTDqW5hcnQgPGFudG9p bmUudGVuYXJ0QGZyZWUtZWxlY3Ryb25zLmNvbT4gd3JvdGU6Cgo+IFNpZ25lZC1vZmYtYnk6IEFu dG9pbmUgVMOpbmFydCA8YW50b2luZS50ZW5hcnRAZnJlZS1lbGVjdHJvbnMuY29tPgo+IC0tLQo+ ICAuLi4vYmluZGluZ3MvcGluY3RybC9tYXJ2ZWxsLGJlcmxpbi1waW5jdHJsLnR4dCAgICB8IDQz Cj4gKysrKysrKysrKysrKysrKysrKysrKyAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygr KQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQKPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvcGluY3RybC9tYXJ2ZWxsLGJlcmxpbi1waW5jdHJsLnR4dAo+IAo+IGRpZmYgLS1naXQKPiBh L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waW5jdHJsL21hcnZlbGwsYmVybGlu LXBpbmN0cmwudHh0Cj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGluY3Ry bC9tYXJ2ZWxsLGJlcmxpbi1waW5jdHJsLnR4dCBuZXcKPiBmaWxlIG1vZGUgMTAwNjQ0IGluZGV4 IDAwMDAwMDAwMDAwMC4uZTIxNTM4YTM3NzM0IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGluY3RybC9tYXJ2ZWxsLGJlcmxpbi1waW5jdHJs LnR4dAo+IEBAIC0wLDAgKzEsNDMgQEAKPiArKiBQaW5jdHJsIGRyaXZlciBmb3IgdGhlIE1hcnZl bGwgQmVybGluIFNvQ3MKPiArCj4gK1RoZSBwaW5zIGNvbnRyb2xsZWQgYnkgdGhlIE1hcnZlbGwg QmVybGluIGNvbnRyb2xsZXIgYXJlIG9yZ2FuaXplZCBpbgo+IGdyb3Vwcy4gK0NvbmZpZ3VyYXRp b24gaXMgZG9uZSBieSBncm91cCwgc28gbm8gYWN0dWFsIHBpbiBpbmZvcm1hdGlvbiBpcwo+IG5l ZWRlZC4gKwo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICstIGNvbXBhdGlibGU6CSJtYXJ2ZWxs LWJlcmxpbjJjZC1waW5jdHJsIiwKPiArCQkibWFydmVsbC1iZXJsaW4yLXBpbmN0cmwiLAo+ICsJ CSJtYXJ2ZWxsLWJlcmxpbjJxLXBpbmN0cmwiCj4gKy0gcmVnOiByZWdpc3RlcnMgcGh5c2ljYWwg YWRkcmVzc2VzIGFuZCBsZW5ndGhzIG9mIHRoZSBwaW4gY29udHJvbGxlci4KPiArLSByZWctbmFt ZXM6IG5hbWUgb2YgdGhlIHJlZ2lzdGVyIHJlZ2lvbnMuCj4gKwo+ICtQbGVhc2UgcmVmZXIgdG8g cGluY3RybC1iaW5kaW5ncy50eHQgaW4gdGhpcyBkaXJlY3RvcnkgZm9yIGRldGFpbHMgb2YgdGhl Cj4gK2NvbW1vbiBwaW5jdHJsIGJpbmRpbmdzIHVzZWQgYnkgY2xpZW50IGRldmljZXMuCj4gKwo+ ICtBIHBpbmN0cmwgc2hvdWxkIGNvbnRhaW5zIHN1Ym5vZGVzIHJlcHJlc2VudGluZyB0aGUgcGlu Y3RybCBwaW4gZ3JvdXAKPiArY29uZmlndXJhdGlvbnMsIG9uZSBwZXIgZ3JvdXAuIEVhY2ggc3Vi bm9kZSBoYXMgdGhlIGdyb3VwIG5hbWUgYW5kIHRoZQo+IG11eGluZyArZnVuY3Rpb24gdXNlZC4K PiArCj4gK1JlcXVpcmVkIHN1Ym5vZGUtcHJvcGVydGllczoKPiArLSBiZXJsaW4sZ3JvdXA6IGEg c3RyaW5nIGRlc2NyaWJpbmcgdGhlIGdyb3VwJ3MgbmFtZS4KPiArLSBiZXJsaW4sZnVuY3Rpb246 IHRoZSBmdW5jdGlvbiB1c2VkIHRvIG11eCB0aGUgZ3JvdXAuCgpXb3VsZCBpdCBiZSBiZXR0ZXIg dG8gcy9mdW5jdGlvbi9tb2RlPyBCZWNhdXNlIGluIG1ydmwgaW50ZXJuYWwgdGVjaG5vbG9neQpk aXNjdXNzaW9uIGFuZCBkb2NzLCB3ZSB1c3VhbGx5IHNheSAic2V0IHBpbm11eCBHeSBhcyBtb2Rl IHoiLgoKClRoYW5rcywKSmlzaGVuZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753755AbaDKGf0 (ORCPT ); Fri, 11 Apr 2014 02:35:26 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:17842 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbaDKGfY convert rfc822-to-8bit (ORCPT ); Fri, 11 Apr 2014 02:35:24 -0400 Date: Fri, 11 Apr 2014 14:33:18 +0800 From: Jisheng Zhang To: Antoine =?UTF-8?B?VMOpbmFydA==?= CC: "sebastian.hesselbarth@gmail.com" , "linus.walleij@linaro.org" , "alexandre.belloni@free-electrons.com" , Jimmy Xu , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation Message-ID: <20140411143318.67e55a17@xhacker> In-Reply-To: <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-04-11_03:2014-04-11,2014-04-11,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404110114 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Apr 2014 06:07:53 -0700 Antoine Ténart wrote: > Signed-off-by: Antoine Ténart > --- > .../bindings/pinctrl/marvell,berlin-pinctrl.txt | 43 > ++++++++++++++++++++++ 1 file changed, 43 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt > > diff --git > a/Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt new > file mode 100644 index 000000000000..e21538a37734 --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/marvell,berlin-pinctrl.txt > @@ -0,0 +1,43 @@ > +* Pinctrl driver for the Marvell Berlin SoCs > + > +The pins controlled by the Marvell Berlin controller are organized in > groups. +Configuration is done by group, so no actual pin information is > needed. + > +Required properties: > +- compatible: "marvell-berlin2cd-pinctrl", > + "marvell-berlin2-pinctrl", > + "marvell-berlin2q-pinctrl" > +- reg: registers physical addresses and lengths of the pin controller. > +- reg-names: name of the register regions. > + > +Please refer to pinctrl-bindings.txt in this directory for details of the > +common pinctrl bindings used by client devices. > + > +A pinctrl should contains subnodes representing the pinctrl pin group > +configurations, one per group. Each subnode has the group name and the > muxing +function used. > + > +Required subnode-properties: > +- berlin,group: a string describing the group's name. > +- berlin,function: the function used to mux the group. Would it be better to s/function/mode? Because in mrvl internal technology discussion and docs, we usually say "set pinmux Gy as mode z". Thanks, Jisheng