From mboxrd@z Thu Jan 1 00:00:00 1970 From: jszhang@marvell.com (Jisheng Zhang) Date: Fri, 11 Apr 2014 16:18:43 +0800 Subject: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation In-Reply-To: <20140411081259.GA20147@kwain> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> <20140411143318.67e55a17@xhacker> <20140411081259.GA20147@kwain> Message-ID: <20140411161843.0bc75185@xhacker> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Antoine, On Fri, 11 Apr 2014 01:12:59 -0700 Antoine T?nart wrote: > Hi Jisheng, > > On Fri, Apr 11, 2014 at 02:33:18PM +0800, Jisheng Zhang wrote: > > On Thu, 10 Apr 2014 06:07:53 -0700 > > Antoine T?nart wrote: > > > +Required subnode-properties: > > > +- berlin,group: a string describing the group's name. > > > +- berlin,function: the function used to mux the group. > > > > Would it be better to s/function/mode? Because in mrvl internal technology > > discussion and docs, we usually say "set pinmux Gy as mode z". > > The pinctrl framework uses 'function', so I guess it's better not to > introduce an other keyword that may confuse people. But I agree this is not > what's used in the Marvell's docs. What do you think about we mention it in > this documentation ? That's a good idea. Thanks, Jisheng From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation Date: Fri, 11 Apr 2014 16:18:43 +0800 Message-ID: <20140411161843.0bc75185@xhacker> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> <20140411143318.67e55a17@xhacker> <20140411081259.GA20147@kwain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140411081259.GA20147@kwain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Antoine =?UTF-8?B?VMOpbmFydA==?= Cc: Jimmy Xu , "devicetree@vger.kernel.org" , "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "alexandre.belloni@free-electrons.com" , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" List-Id: devicetree@vger.kernel.org SGkgQW50b2luZSwKCk9uIEZyaSwgMTEgQXByIDIwMTQgMDE6MTI6NTkgLTA3MDAKQW50b2luZSBU w6luYXJ0IDxhbnRvaW5lLnRlbmFydEBmcmVlLWVsZWN0cm9ucy5jb20+IHdyb3RlOgoKPiBIaSBK aXNoZW5nLAo+IAo+IE9uIEZyaSwgQXByIDExLCAyMDE0IGF0IDAyOjMzOjE4UE0gKzA4MDAsIEpp c2hlbmcgWmhhbmcgd3JvdGU6Cj4gPiBPbiBUaHUsIDEwIEFwciAyMDE0IDA2OjA3OjUzIC0wNzAw Cj4gPiBBbnRvaW5lIFTDqW5hcnQgPGFudG9pbmUudGVuYXJ0QGZyZWUtZWxlY3Ryb25zLmNvbT4g d3JvdGU6Cj4gPiA+ICtSZXF1aXJlZCBzdWJub2RlLXByb3BlcnRpZXM6Cj4gPiA+ICstIGJlcmxp bixncm91cDogYSBzdHJpbmcgZGVzY3JpYmluZyB0aGUgZ3JvdXAncyBuYW1lLgo+ID4gPiArLSBi ZXJsaW4sZnVuY3Rpb246IHRoZSBmdW5jdGlvbiB1c2VkIHRvIG11eCB0aGUgZ3JvdXAuCj4gPiAK PiA+IFdvdWxkIGl0IGJlIGJldHRlciB0byBzL2Z1bmN0aW9uL21vZGU/IEJlY2F1c2UgaW4gbXJ2 bCBpbnRlcm5hbCB0ZWNobm9sb2d5Cj4gPiBkaXNjdXNzaW9uIGFuZCBkb2NzLCB3ZSB1c3VhbGx5 IHNheSAic2V0IHBpbm11eCBHeSBhcyBtb2RlIHoiLgo+IAo+IFRoZSBwaW5jdHJsIGZyYW1ld29y ayB1c2VzICdmdW5jdGlvbicsIHNvIEkgZ3Vlc3MgaXQncyBiZXR0ZXIgbm90IHRvCj4gaW50cm9k dWNlIGFuIG90aGVyIGtleXdvcmQgdGhhdCBtYXkgY29uZnVzZSBwZW9wbGUuIEJ1dCBJIGFncmVl IHRoaXMgaXMgbm90Cj4gd2hhdCdzIHVzZWQgaW4gdGhlIE1hcnZlbGwncyBkb2NzLiBXaGF0IGRv IHlvdSB0aGluayBhYm91dCB3ZSBtZW50aW9uIGl0IGluCj4gdGhpcyBkb2N1bWVudGF0aW9uID8K ClRoYXQncyBhIGdvb2QgaWRlYS4KClRoYW5rcywKSmlzaGVuZwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755843AbaDKIUx (ORCPT ); Fri, 11 Apr 2014 04:20:53 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:37778 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755380AbaDKIUs convert rfc822-to-8bit (ORCPT ); Fri, 11 Apr 2014 04:20:48 -0400 Date: Fri, 11 Apr 2014 16:18:43 +0800 From: Jisheng Zhang To: Antoine =?UTF-8?B?VMOpbmFydA==?= CC: "sebastian.hesselbarth@gmail.com" , "linus.walleij@linaro.org" , "alexandre.belloni@free-electrons.com" , Jimmy Xu , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation Message-ID: <20140411161843.0bc75185@xhacker> In-Reply-To: <20140411081259.GA20147@kwain> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-5-git-send-email-antoine.tenart@free-electrons.com> <20140411143318.67e55a17@xhacker> <20140411081259.GA20147@kwain> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-04-11_03:2014-04-11,2014-04-11,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404110140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antoine, On Fri, 11 Apr 2014 01:12:59 -0700 Antoine Ténart wrote: > Hi Jisheng, > > On Fri, Apr 11, 2014 at 02:33:18PM +0800, Jisheng Zhang wrote: > > On Thu, 10 Apr 2014 06:07:53 -0700 > > Antoine Ténart wrote: > > > +Required subnode-properties: > > > +- berlin,group: a string describing the group's name. > > > +- berlin,function: the function used to mux the group. > > > > Would it be better to s/function/mode? Because in mrvl internal technology > > discussion and docs, we usually say "set pinmux Gy as mode z". > > The pinctrl framework uses 'function', so I guess it's better not to > introduce an other keyword that may confuse people. But I agree this is not > what's used in the Marvell's docs. What do you think about we mention it in > this documentation ? That's a good idea. Thanks, Jisheng