From: Lauri Kasanen <cand@gmx.com>
To: "Christian König" <deathsimple@vodafone.de>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/radeon: Inline r100_mm_rreg
Date: Fri, 11 Apr 2014 19:47:36 +0300 [thread overview]
Message-ID: <20140411194736.01195730.cand@gmx.com> (raw)
In-Reply-To: <5347E0D4.3040205@vodafone.de>
On Fri, 11 Apr 2014 14:32:20 +0200
Christian König <deathsimple@vodafone.de> wrote:
> Anyway, I would do like Ilia suggested and only put the else branch into
> a separate, not inlined function.
>
> BTW: It's probably a good idea to do the same for the write function as
> well.
I tested it. The majority of the size increase stayed - the
else/spinlock part as non-inlined functions, radeon.ko was still 5%
larger instead of 7%.
- Lauri
next prev parent reply other threads:[~2014-04-11 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 13:08 [PATCH] drm/radeon: Inline r100_mm_rreg Lauri Kasanen
2014-04-10 16:19 ` Ilia Mirkin
2014-04-10 18:46 ` Lauri Kasanen
2014-04-10 18:52 ` Ilia Mirkin
2014-04-10 19:30 ` Christian König
2014-04-11 7:52 ` Lauri Kasanen
2014-04-11 8:33 ` Christian König
2014-04-11 9:54 ` Lauri Kasanen
2014-04-11 12:32 ` Christian König
2014-04-11 16:47 ` Lauri Kasanen [this message]
2014-04-11 17:38 ` Lauri Kasanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411194736.01195730.cand@gmx.com \
--to=cand@gmx.com \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.