From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dave Hansen <dave@sr71.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: pass VM_BUG_ON() reason to dump_page()
Date: Fri, 11 Apr 2014 23:36:57 +0300 [thread overview]
Message-ID: <20140411203657.GA672@node.dhcp.inet.fi> (raw)
In-Reply-To: <20140411202125.01D1D100@viggo.jf.intel.com>
On Fri, Apr 11, 2014 at 01:21:25PM -0700, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> I recently added a patch to let folks pass a "reason" string
> dump_page() which gets dumped out along with the page's data.
> This essentially saves the bug-reader a trip in to the source
> to figure out why we BUG_ON()'d.
>
> The new VM_BUG_ON_PAGE() passes in NULL for "reason". It seems
> like we might as well pass the BUG_ON() condition if we have it.
> This will bloat kernels a bit with ~160 new strings, but this
> is all under a debugging option anyway.
>
> page:ffffea0008560280 count:1 mapcount:0 mapping:(null) index:0x0
> page flags: 0xbfffc0000000001(locked)
> page dumped because: VM_BUG_ON_PAGE(PageLocked(page))
> ------------[ cut here ]------------
> kernel BUG at /home/davehans/linux.git/mm/filemap.c:464!
> invalid opcode: 0000 [#1] SMP
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.0+ #251
> Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
> ...
>
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
I see space-before-tabs in few places, otherwise:
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
prev parent reply other threads:[~2014-04-11 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 20:21 [PATCH] mm: pass VM_BUG_ON() reason to dump_page() Dave Hansen
2014-04-11 20:21 ` Dave Hansen
2014-04-11 20:36 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411203657.GA672@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.