From: Theodore Ts'o <tytso@mit.edu>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
rostedt@goodmis.org
Subject: Re: Pretty-printing file.f_mode and file.f_flags in trace points
Date: Fri, 11 Apr 2014 18:57:04 -0400 [thread overview]
Message-ID: <20140411225704.GA30629@thunk.org> (raw)
In-Reply-To: <FEAE2135-C0C3-409C-A162-9BC3D9ABDECA@primarydata.com>
On Fri, Apr 11, 2014 at 06:47:52PM -0400, Trond Myklebust wrote:
> > I could just cut and paste these and drop them in
> > include/trace/events/ext4.h, but it would probably be better to have a
> > common header file. The question is where to put them. Does
> > include/trace/fs.h make sense to everyone? Or should put them
> > somewhere else, such as linux/fs.h?
>
> I’d vote for creating a new file, rather than reusing
> include/linux/fs.h. The latter is included in way too many other
> headers...
That was my preference as well. Assuming Steve is OK with
include/trace/fs.h, any objections if I carry a patch in the ext4 tree
which moves these macros from fs/nfs/nfstrace.h into that new file?
Cheers,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-11 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 22:32 Pretty-printing file.f_mode and file.f_flags in trace points Theodore Ts'o
2014-04-11 22:47 ` Trond Myklebust
2014-04-11 22:57 ` Theodore Ts'o [this message]
2014-04-11 23:00 ` Trond Myklebust
2014-04-12 1:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411225704.GA30629@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.