From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Namjae Jeon <namjae.jeon@samsung.com>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] ext4: fix some warnings from sparse check introduced by COLLAPSE_RANGE patches
Date: Sat, 12 Apr 2014 13:23:52 -0400 [thread overview]
Message-ID: <20140412172352.GH13837@thunk.org> (raw)
In-Reply-To: <1397294178-20383-1-git-send-email-wenqing.lz@taobao.com>
On Sat, Apr 12, 2014 at 05:16:18PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> This commit tries to fix some byte order issues that is found by sparse
> check.
>
> $ make M=fs/ext4 C=2 CF=-D__CHECK_ENDIAN__
> ...
> CHECK fs/ext4/extents.c
> fs/ext4/extents.c:5232:41: warning: restricted __le32 degrades to integer
> fs/ext4/extents.c:5236:52: warning: bad assignment (-=) to restricted __le32
> fs/ext4/extents.c:5258:45: warning: bad assignment (-=) to restricted __le32
> fs/ext4/extents.c:5303:28: warning: restricted __le32 degrades to integer
> fs/ext4/extents.c:5318:18: warning: incorrect type in assignment (different base types)
> fs/ext4/extents.c:5318:18: expected unsigned int [unsigned] [usertype] ex_start
> fs/ext4/extents.c:5318:18: got restricted __le32 [usertype] ee_block
> fs/ext4/extents.c:5319:24: warning: restricted __le32 degrades to integer
> fs/ext4/extents.c:5334:31: warning: incorrect type in assignment (different base types)
> ...
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Thanks, queued for the 3.15 bugfix push.
- Ted
prev parent reply other threads:[~2014-04-12 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 9:16 [PATCH] ext4: fix some warnings from sparse check introduced by COLLAPSE_RANGE patches Zheng Liu
2014-04-12 17:23 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140412172352.GH13837@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.