From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: XFS Filesystem <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix xfs_logprint EFI entry split on log buffer
Date: Mon, 14 Apr 2014 11:42:12 +1000 [thread overview]
Message-ID: <20140414014212.GG27694@dastard> (raw)
In-Reply-To: <20140409210048.859660076@sgi.com>
On Wed, Apr 09, 2014 at 04:00:14PM -0500, Mark Tinguely wrote:
> xfs_logprint does not correctly handle EFI entries that
> are split across two log buffers. xfs_efi_copy_format()
> falsely interrupts the truncated size of the split entry
> as being a corrupt entry.
>
> If the first log entry has enough information, namely the
> number of extents in the entry and the identifier, then
> display this information and a warning that this entry is
> truncated. Otherwise, if there is not enough information in
> the first log buffer, then print a message that the EFI decode
> was not possible. These messages are similar to split inode
> entries.
>
> Example of a continued entry:
> Oper (336): tid: f214bdb len: 44 clientid: TRANS flags: CONTINUE
> EFI: #regs: 1 num_extents: 2 id: 0xffff880804f63900
> EFI free extent data skipped (CONTINUE set, no space)
>
> Reported-by: Michael L. Semon <mlsemon35@gmail.com>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-14 1:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140409210013.095709266@sgi.com>
2014-04-09 21:00 ` [PATCH] xfsprogs: fix xfs_logprint EFI entry split on log buffer Mark Tinguely
2014-04-14 1:42 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414014212.GG27694@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.