All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Robert Yang <liezhi.yang@windriver.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH V2] e2fsprogs: misc/mke2fs.c: return error when failed to populate fs
Date: Mon, 14 Apr 2014 11:44:12 -0400	[thread overview]
Message-ID: <20140414154412.GA26487@thunk.org> (raw)
In-Reply-To: <20140330090825.GA4394@gmail.com>

On Sun, Mar 30, 2014 at 05:08:25PM +0800, Zheng Liu wrote:
> On Thu, Mar 27, 2014 at 10:03:07AM +0800, Robert Yang wrote:
> > We need return retval when "mke2fs -d" failed, otherwise the "$?" would
> > be 0 which is misleading.
> > 
> > Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> 
> Thanks for fixing this.
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>

Thanks, applied.

						- Ted

      reply	other threads:[~2014-04-14 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  2:03 [PATCH V2] e2fsprogs: misc/mke2fs.c: return error when failed to populate fs Robert Yang
2014-03-30  9:08 ` Zheng Liu
2014-04-14 15:44   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140414154412.GA26487@thunk.org \
    --to=tytso@mit.edu \
    --cc=liezhi.yang@windriver.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.