From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: dm-verity: Fix biovecs hash calculation regression Date: Mon, 14 Apr 2014 17:11:20 -0400 Message-ID: <20140414211119.GA24873@redhat.com> References: <1397505750-18783-1-git-send-email-gmazyland@gmail.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: dm-devel@redhat.com, kmo@daterainc.com, Milan Broz List-Id: dm-devel.ids On Mon, Apr 14 2014 at 4:29pm -0400, Mikulas Patocka wrote: > > > On Mon, 14 Apr 2014, Milan Broz wrote: > > > The commit > > 003b5c5719f159f4f4bf97511c4702a0638313dd > > block: Convert drivers to immutable biovecs > > > > incorrectly converted biovec iteration in dm-verity to always > > calculate hash from full biovec, while the function need > > to calculate hash only from part of it (up to "todo" > > calculated value). > > > > This patch fixes the issue by limiting hash input to only > > really requested data size. > > > > The problem is easily reproducible using cryptsetup > > regression test for veritysetup (verity-compat-test). > > > > (Patch should be applied also to 3.14 stable.) > > > > Signed-off-by: Milan Broz > > Acked-by: Mikulas Patocka > Cc: stable@vger.kernel.org # 3.14 I'll pick this up to include in 3.15 fixes that I'll be sending to Linus.