From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] set: add helper to get the first set_elem
Date: Tue, 15 Apr 2014 10:11:24 +0200 [thread overview]
Message-ID: <20140415081124.GA3675@localhost> (raw)
In-Reply-To: <20140415080432.GA15759@macbook.localnet>
On Tue, Apr 15, 2014 at 10:04:32AM +0200, Patrick McHardy wrote:
> On Tue, Apr 15, 2014 at 09:58:42AM +0200, Arturo Borrero Gonzalez wrote:
> > Add a helper that returns a pointer to the first set_elem in a given set.
> >
> > This function is useful in situations where you know the set only have one
> > element (ie, event reporting from the kernel).
>
> That doesn't seem right to me. As I said in my review of the notification
> patch, userspace *must* be prepared for multiple elements being reported
> at once since it is very likely that we will change the kernel side in
> the future for efficiency reasons.
I see. Arturo, you have to consider that the set may have more than
one element in the event from userspace, even if currently we only
have one single element. So use the set iterator to print all the
elements in the set instead.
next prev parent reply other threads:[~2014-04-15 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 7:58 [libnftnl PATCH] set: add helper to get the first set_elem Arturo Borrero Gonzalez
2014-04-15 8:04 ` Patrick McHardy
2014-04-15 8:11 ` Pablo Neira Ayuso [this message]
2014-04-15 8:44 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415081124.GA3675@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.