From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 15 Apr 2014 15:38:21 +0200 Subject: [U-Boot] [PATCH v4 04/13] usb: dfu: fix boards wo USB cable detection In-Reply-To: <1397567221-2065-5-git-send-email-m.zalega@samsung.com> References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> <1397567221-2065-1-git-send-email-m.zalega@samsung.com> <1397567221-2065-5-git-send-email-m.zalega@samsung.com> Message-ID: <201404151538.21605.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, April 15, 2014 at 03:06:52 PM, Mateusz Zalega wrote: > Former usb_cable_connected() patch broke compilation of boards which do > not support this feature. > > Signed-off-by: Mateusz Zalega > Cc: Lukasz Majewski > Cc: Marek Vasut > Cc: Minkyu Kang I suggest we go for the weak default implementation of usb_cable_connected() which would return -ENOTSUP in the default case. Override with board-specific stuff if needed. Best regards, Marek Vasut