From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file Date: Wed, 16 Apr 2014 07:36:35 +1000 Message-ID: <20140415213635.GM15995@dastard> References: <1397242665-2183-1-git-send-email-lczerner@redhat.com> <1397242665-2183-2-git-send-email-lczerner@redhat.com> <20140412151935.GA18047@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org To: =?utf-8?B?THVrw6HFoQ==?= Czerner Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com List-Id: ceph-devel.vger.kernel.org On Tue, Apr 15, 2014 at 03:09:42PM +0200, Luk=C3=A1=C5=A1 Czerner wrote= : > On Sat, 12 Apr 2014, Christoph Hellwig wrote: >=20 > > Date: Sat, 12 Apr 2014 08:19:35 -0700 > > From: Christoph Hellwig > > To: Lukas Czerner > > Cc: linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, > > linux-ext4@vger.kernel.org, xfs@oss.sgi.com > > Subject: Re: [PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on = append only > > file > >=20 > > On Fri, Apr 11, 2014 at 08:57:43PM +0200, Lukas Czerner wrote: > > > /* > > > - * It's not possible to punch hole or perform collapse range > > > - * on append only file > > > + * It's not possible to punch hole, perform collapse range > > > + * or zero range on append only file > > > */ > > > - if (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE) > > > + if (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE | > > > + FALLOC_FL_ZERO_RANGE) > >=20 > > Might be better to make this a negative test fo the operation that = is > > allowed on an appen only file. That's also much better future proo= f. > >=20 >=20 > True, it might be better to do it this way: >=20 > if (mode & ~FALLOC_FL_KEEP_SIZE && IS_APPEND(inode)) if ((mode & ~FALLOC_FL_KEEP_SIZE) && IS_APPEND(inode)) :) Cheers, Dave. --=20 Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id DF52C7F3F for ; Tue, 15 Apr 2014 16:36:53 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id BE61B304077 for ; Tue, 15 Apr 2014 14:36:50 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id R8M9c9WODZ3SgDah for ; Tue, 15 Apr 2014 14:36:48 -0700 (PDT) Date: Wed, 16 Apr 2014 07:36:35 +1000 From: Dave Chinner Subject: Re: [PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file Message-ID: <20140415213635.GM15995@dastard> References: <1397242665-2183-1-git-send-email-lczerner@redhat.com> <1397242665-2183-2-git-send-email-lczerner@redhat.com> <20140412151935.GA18047@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: =?utf-8?B?THVrw6HFoQ==?= Czerner Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com T24gVHVlLCBBcHIgMTUsIDIwMTQgYXQgMDM6MDk6NDJQTSArMDIwMCwgTHVrw6HFoSBDemVybmVy IHdyb3RlOgo+IE9uIFNhdCwgMTIgQXByIDIwMTQsIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOgo+ IAo+ID4gRGF0ZTogU2F0LCAxMiBBcHIgMjAxNCAwODoxOTozNSAtMDcwMAo+ID4gRnJvbTogQ2hy aXN0b3BoIEhlbGx3aWcgPGhjaEBpbmZyYWRlYWQub3JnPgo+ID4gVG86IEx1a2FzIEN6ZXJuZXIg PGxjemVybmVyQHJlZGhhdC5jb20+Cj4gPiBDYzogbGludXgtZnNkZXZlbEB2Z2VyLmtlcm5lbC5v cmcsIGNlcGgtZGV2ZWxAdmdlci5rZXJuZWwub3JnLAo+ID4gICAgIGxpbnV4LWV4dDRAdmdlci5r ZXJuZWwub3JnLCB4ZnNAb3NzLnNnaS5jb20KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMi80XSBm czogUHJldmVudCBkb2luZyBGQUxMT0NfRkxfWkVST19SQU5HRSBvbiBhcHBlbmQgb25seQo+ID4g ICAgICBmaWxlCj4gPiAKPiA+IE9uIEZyaSwgQXByIDExLCAyMDE0IGF0IDA4OjU3OjQzUE0gKzAy MDAsIEx1a2FzIEN6ZXJuZXIgd3JvdGU6Cj4gPiA+ICAJLyoKPiA+ID4gLQkgKiBJdCdzIG5vdCBw b3NzaWJsZSB0byBwdW5jaCBob2xlIG9yIHBlcmZvcm0gY29sbGFwc2UgcmFuZ2UKPiA+ID4gLQkg KiBvbiBhcHBlbmQgb25seSBmaWxlCj4gPiA+ICsJICogSXQncyBub3QgcG9zc2libGUgdG8gcHVu Y2ggaG9sZSwgcGVyZm9ybSBjb2xsYXBzZSByYW5nZQo+ID4gPiArCSAqIG9yIHplcm8gcmFuZ2Ug b24gYXBwZW5kIG9ubHkgZmlsZQo+ID4gPiAgCSAqLwo+ID4gPiAtCWlmIChtb2RlICYgKEZBTExP Q19GTF9QVU5DSF9IT0xFIHwgRkFMTE9DX0ZMX0NPTExBUFNFX1JBTkdFKQo+ID4gPiArCWlmICht b2RlICYgKEZBTExPQ19GTF9QVU5DSF9IT0xFIHwgRkFMTE9DX0ZMX0NPTExBUFNFX1JBTkdFIHwK PiA+ID4gKwkJICAgIEZBTExPQ19GTF9aRVJPX1JBTkdFKQo+ID4gCj4gPiBNaWdodCBiZSBiZXR0 ZXIgdG8gbWFrZSB0aGlzIGEgbmVnYXRpdmUgdGVzdCBmbyB0aGUgb3BlcmF0aW9uIHRoYXQgaXMK PiA+IGFsbG93ZWQgb24gYW4gYXBwZW4gb25seSBmaWxlLiAgVGhhdCdzIGFsc28gbXVjaCBiZXR0 ZXIgZnV0dXJlIHByb29mLgo+ID4gCj4gCj4gVHJ1ZSwgaXQgbWlnaHQgYmUgYmV0dGVyIHRvIGRv IGl0IHRoaXMgd2F5Ogo+IAo+IGlmIChtb2RlICYgfkZBTExPQ19GTF9LRUVQX1NJWkUgJiYgSVNf QVBQRU5EKGlub2RlKSkKCmlmICgobW9kZSAmIH5GQUxMT0NfRkxfS0VFUF9TSVpFKSAmJiBJU19B UFBFTkQoaW5vZGUpKQoKOikKCkNoZWVycywKCkRhdmUuCi0tIApEYXZlIENoaW5uZXIKZGF2aWRA ZnJvbW9yYml0LmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KeGZzIG1haWxpbmcgbGlzdAp4ZnNAb3NzLnNnaS5jb20KaHR0cDovL29zcy5zZ2kuY29t L21haWxtYW4vbGlzdGluZm8veGZzCg==