From: Vinod Koul <vinod.koul@intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: dmaengine@vger.kernel.org, linux-media@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH] [media] platform: Fix timberdale dependencies
Date: Wed, 16 Apr 2014 11:57:54 +0530 [thread overview]
Message-ID: <20140416062754.GI32284@intel.com> (raw)
In-Reply-To: <20140403113206.0aab763f@endymion.delvare>
On Thu, Apr 03, 2014 at 11:32:06AM +0200, Jean Delvare wrote:
> VIDEO_TIMBERDALE selects TIMB_DMA which itself depends on
> MFD_TIMBERDALE, so VIDEO_TIMBERDALE should either select or depend on
> MFD_TIMBERDALE as well. I chose to make it depend on it because I
> think it makes more sense and it is consistent with what other options
> are doing.
>
> Adding a "|| HAS_IOMEM" to the TIMB_DMA dependencies silenced the
> kconfig warning about unmet direct dependencies but it was wrong:
> without MFD_TIMBERDALE, TIMB_DMA is useless as the driver has no
> device to bind to.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2014-04-16 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 9:32 [PATCH] [media] platform: Fix timberdale dependencies Jean Delvare
2014-04-16 6:27 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416062754.GI32284@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.