From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thomas Tanaka <thomas.tanaka@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
bernat.ada@gmail.com, jg1.han@samsung.com, keescook@chromium.org,
peter.p.waskiewicz.jr@intel.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] staging: dgrp: Fixed coding style
Date: Wed, 16 Apr 2014 10:44:10 +0300 [thread overview]
Message-ID: <20140416074410.GO26890@mwanda> (raw)
In-Reply-To: <1397609680-10321-1-git-send-email-thomas.tanaka@gmail.com>
On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote:
> Fixed line width > 80
>
> Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com>
> ---
> drivers/staging/dgrp/dgrp_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging/dgrp/dgrp_sysfs.c
> index 2f9345f..93803e0c 100644
> --- a/drivers/staging/dgrp/dgrp_sysfs.c
> +++ b/drivers/staging/dgrp/dgrp_sysfs.c
> @@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
> ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
> &dgrp_global_settings_attribute_group);
> if (ret) {
> - pr_alert("%s: failed to create sysfs global settings device attributes.\n",
> - __func__);
> + pr_alert("%s: failed to create sysfs global settings device
> + attributes.\n", __func__);
The original was fine. It doesn't cause a checkpatch.pl warning. The
new one is buggy and won't print the correct text.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-16 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 0:54 [PATCH] staging: dgrp: Fixed coding style Thomas Tanaka
2014-04-16 7:44 ` Dan Carpenter [this message]
2014-04-16 7:54 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416074410.GO26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bernat.ada@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=thomas.tanaka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.