From: Lee Jones <lee.jones@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: sameo@linux.intel.com, linux@arm.linux.org.uk,
linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] mfd: mc13xxx-core: Initialize the lock prior to using it
Date: Wed, 16 Apr 2014 10:15:31 +0100 [thread overview]
Message-ID: <20140416091531.GD4754@lee--X1> (raw)
In-Reply-To: <1397602574-28025-1-git-send-email-festevam@gmail.com>
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> After request_threaded_irq() is called there is a chance that an interrupt
> may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel
> oops.
>
> In order to prevent that, move the initialization of 'mc13xxx->lock' prior to
> requesting the interrupts.
>
> Suggested-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Changed kernel warning --> kernel oops to better describe the problem
> - Added Russell's Ack
No you didn't. ;)
Applied with Russell's Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-04-16 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 22:56 [PATCH v2] mfd: mc13xxx-core: Initialize the lock prior to using it Fabio Estevam
2014-04-16 9:15 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416091531.GD4754@lee--X1 \
--to=lee.jones@linaro.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.