From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine =?iso-8859-1?Q?T=E9nart?= Subject: Re: [PATCH 3/4] ARM: dts: berlin: add the SDHCI nodes for the BG2Q Date: Wed, 16 Apr 2014 15:23:13 +0200 Message-ID: <20140416132313.GA6253@kwain> References: <1397652011-21284-1-git-send-email-antoine.tenart@free-electrons.com> <1397652011-21284-4-git-send-email-antoine.tenart@free-electrons.com> <20140416130915.GC11310@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140416130915.GC11310-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Cc: sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, chris-OsFVWbfNK3isTnJN9+BGXg@public.gmane.org, anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org, zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mmc@vger.kernel.org Hi Andrew, On Wed, Apr 16, 2014 at 03:09:15PM +0200, Andrew Lunn wrote: > On Wed, Apr 16, 2014 at 02:40:10PM +0200, Antoine T=E9nart wrote: > > Add the SDHCI nodes for the Marvell Berlin BG2Q, using the berlin-s= dhci > > driver. > >=20 > > Signed-off-by: Antoine T=E9nart > > --- > > arch/arm/boot/dts/berlin2q.dtsi | 40 +++++++++++++++++++++++++++++= +++++++++++ > > 1 file changed, 40 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/be= rlin2q.dtsi > > index 5925e6a16749..8f897d461460 100644 > > --- a/arch/arm/boot/dts/berlin2q.dtsi > > +++ b/arch/arm/boot/dts/berlin2q.dtsi > > @@ -67,6 +67,14 @@ > > clock-div =3D <3>; > > }; > > =20 > > + sdio1clk: sdio1clk { > > + compatible =3D "fixed-factor-clock"; > > + #clock-cells =3D <0>; > > + clocks =3D <&syspll>; > > + clock-mult =3D <1>; > > + clock-div =3D <4>; > > + }; > > + > > soc { > > compatible =3D "simple-bus"; > > #address-cells =3D <1>; > > @@ -75,6 +83,38 @@ > > ranges =3D <0 0xf7000000 0x1000000>; > > interrupt-parent =3D <&gic>; > > =20 > > + sdhci0: sdhci@ab0000 { > > + compatible =3D "marvell,berlin2q-sdhci"; > > + reg =3D <0xab0000 0x200>; > > + clocks =3D <&sdio1clk>; > > + interrupts =3D ; > > + keep-power-in-suspend; > > + enable-sdio-wakeup; > > + broken-cd; >=20 > Hi Antoine >=20 > I would expect these three last properties to be a property of the > board, not the SoC. Or am i missing something? No reason, I'll move them. Thanks ! Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: antoine.tenart@free-electrons.com (Antoine =?iso-8859-1?Q?T=E9nart?=) Date: Wed, 16 Apr 2014 15:23:13 +0200 Subject: [PATCH 3/4] ARM: dts: berlin: add the SDHCI nodes for the BG2Q In-Reply-To: <20140416130915.GC11310@lunn.ch> References: <1397652011-21284-1-git-send-email-antoine.tenart@free-electrons.com> <1397652011-21284-4-git-send-email-antoine.tenart@free-electrons.com> <20140416130915.GC11310@lunn.ch> Message-ID: <20140416132313.GA6253@kwain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrew, On Wed, Apr 16, 2014 at 03:09:15PM +0200, Andrew Lunn wrote: > On Wed, Apr 16, 2014 at 02:40:10PM +0200, Antoine T?nart wrote: > > Add the SDHCI nodes for the Marvell Berlin BG2Q, using the berlin-sdhci > > driver. > > > > Signed-off-by: Antoine T?nart > > --- > > arch/arm/boot/dts/berlin2q.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi > > index 5925e6a16749..8f897d461460 100644 > > --- a/arch/arm/boot/dts/berlin2q.dtsi > > +++ b/arch/arm/boot/dts/berlin2q.dtsi > > @@ -67,6 +67,14 @@ > > clock-div = <3>; > > }; > > > > + sdio1clk: sdio1clk { > > + compatible = "fixed-factor-clock"; > > + #clock-cells = <0>; > > + clocks = <&syspll>; > > + clock-mult = <1>; > > + clock-div = <4>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > #address-cells = <1>; > > @@ -75,6 +83,38 @@ > > ranges = <0 0xf7000000 0x1000000>; > > interrupt-parent = <&gic>; > > > > + sdhci0: sdhci at ab0000 { > > + compatible = "marvell,berlin2q-sdhci"; > > + reg = <0xab0000 0x200>; > > + clocks = <&sdio1clk>; > > + interrupts = ; > > + keep-power-in-suspend; > > + enable-sdio-wakeup; > > + broken-cd; > > Hi Antoine > > I would expect these three last properties to be a property of the > board, not the SoC. Or am i missing something? No reason, I'll move them. Thanks ! Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161059AbaDPNXS (ORCPT ); Wed, 16 Apr 2014 09:23:18 -0400 Received: from top.free-electrons.com ([176.31.233.9]:48323 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756041AbaDPNXR (ORCPT ); Wed, 16 Apr 2014 09:23:17 -0400 Date: Wed, 16 Apr 2014 15:23:13 +0200 From: Antoine =?iso-8859-1?Q?T=E9nart?= To: Andrew Lunn Cc: sebastian.hesselbarth@gmail.com, chris@printf.net, anton@enomsg.org, zmxu@marvell.com, jszhang@marvell.com, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/4] ARM: dts: berlin: add the SDHCI nodes for the BG2Q Message-ID: <20140416132313.GA6253@kwain> References: <1397652011-21284-1-git-send-email-antoine.tenart@free-electrons.com> <1397652011-21284-4-git-send-email-antoine.tenart@free-electrons.com> <20140416130915.GC11310@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140416130915.GC11310@lunn.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Wed, Apr 16, 2014 at 03:09:15PM +0200, Andrew Lunn wrote: > On Wed, Apr 16, 2014 at 02:40:10PM +0200, Antoine Ténart wrote: > > Add the SDHCI nodes for the Marvell Berlin BG2Q, using the berlin-sdhci > > driver. > > > > Signed-off-by: Antoine Ténart > > --- > > arch/arm/boot/dts/berlin2q.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi > > index 5925e6a16749..8f897d461460 100644 > > --- a/arch/arm/boot/dts/berlin2q.dtsi > > +++ b/arch/arm/boot/dts/berlin2q.dtsi > > @@ -67,6 +67,14 @@ > > clock-div = <3>; > > }; > > > > + sdio1clk: sdio1clk { > > + compatible = "fixed-factor-clock"; > > + #clock-cells = <0>; > > + clocks = <&syspll>; > > + clock-mult = <1>; > > + clock-div = <4>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > #address-cells = <1>; > > @@ -75,6 +83,38 @@ > > ranges = <0 0xf7000000 0x1000000>; > > interrupt-parent = <&gic>; > > > > + sdhci0: sdhci@ab0000 { > > + compatible = "marvell,berlin2q-sdhci"; > > + reg = <0xab0000 0x200>; > > + clocks = <&sdio1clk>; > > + interrupts = ; > > + keep-power-in-suspend; > > + enable-sdio-wakeup; > > + broken-cd; > > Hi Antoine > > I would expect these three last properties to be a property of the > board, not the SoC. Or am i missing something? No reason, I'll move them. Thanks ! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com