From: oleg@redhat.com (Oleg Nesterov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3] ARM: uprobes need icache flush after xol write
Date: Wed, 16 Apr 2014 17:06:46 +0200 [thread overview]
Message-ID: <20140416150646.GB11039@redhat.com> (raw)
In-Reply-To: <1397623112-3211-2-git-send-email-victor.kamensky@linaro.org>
On 04/15, Victor Kamensky wrote:
>
> arch/arm/include/asm/cacheflush.h | 2 ++
> arch/arm/kernel/uprobes.c | 22 ++++++++++++++++++++++
> arch/arm/mm/flush.c | 33 ++++++++++++++++++++++++++++-----
> include/linux/uprobes.h | 3 +++
> kernel/events/uprobes.c | 25 +++++++++++++++++--------
Obviously I can't comment the changes in arm/ ;)
But I'd vote for this patch.
Off-topic, I am just curious... can't someone explain why flush_pfn_alias()
or flush_icache_alias() can't race with itself ? I have no idea what they do,
but what if another thread calls the same function with the same CACHE_COLOUR()
right after set_pte_ext?
Oleg.
next prev parent reply other threads:[~2014-04-16 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 4:38 [RFC PATCH v3] ARM: uprobes need icache flush after xol write Victor Kamensky
2014-04-16 4:38 ` Victor Kamensky
2014-04-16 15:06 ` Oleg Nesterov [this message]
2014-04-16 15:10 ` David Miller
[not found] ` <20140416152946.GA13564@redhat.com>
2014-04-16 15:47 ` David Miller
2014-04-16 16:53 ` Oleg Nesterov
2014-04-16 20:22 ` Russell King - ARM Linux
2014-04-16 21:13 ` David Miller
2014-04-25 20:16 ` David Long
2014-04-25 20:37 ` Victor Kamensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416150646.GB11039@redhat.com \
--to=oleg@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.