All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [PATCH] build: delete useless characters
Date: Wed, 16 Apr 2014 18:32:59 +0200	[thread overview]
Message-ID: <20140416163258.GA30296@macbook.localnet> (raw)
In-Reply-To: <20140416161038.1237.5216.stgit@nfdev.cica.es>

On Wed, Apr 16, 2014 at 06:10:38PM +0200, Arturo Borrero Gonzalez wrote:
> There are a lot of '-e' that seem useless in the build system.
> 
> Previous to this patch:
>   [...]
>   -e CC		src/evaluate.c
>   -e CC		src/expression.c
>   -e CC		src/proto.c
>   [...]
> 
> 
> With this patch:
>   [...]
>   CC		src/evaluate.c
>   CC		src/expression.c
>   CC		src/proto.c
>   [...]

I assume you're on debian? The -e is needed to interpret the backslash
sequences like \t. Something is broken about the echo command in debian,
I'd assume its using the shell internal one instead of /bin/echo.

This needs to be fixed differently:

  CC\t\tsrc/main.c
  CC\t\tsrc/cli.c
  CC\t\tsrc/rule.c
  CC\t\tsrc/statement.c
  CC\t\tsrc/datatype.c
  CC\t\tsrc/expression.c
  CC\t\tsrc/evaluate.c
  CC\t\tsrc/proto.c
  CC\t\tsrc/payload.c
  CC\t\tsrc/exthdr.c
  CC\t\tsrc/meta.c
  CC\t\tsrc/ct.c
  CC\t\tsrc/netlink.c
  CC\t\tsrc/netlink_linearize.c
  CC\t\tsrc/netlink_delinearize.c
  CC\t\tsrc/segtree.c
  CC\t\tsrc/rbtree.c
  CC\t\tsrc/gmputil.c
  CC\t\tsrc/utils.c
  CC\t\tsrc/erec.c
  CC\t\tsrc/mnl.c
  CC\t\tsrc/hipac.c
  CC\t\tsrc/parser.c
  CC\t\tsrc/scanner.c


  reply	other threads:[~2014-04-16 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 16:10 [PATCH] build: delete useless characters Arturo Borrero Gonzalez
2014-04-16 16:32 ` Patrick McHardy [this message]
2014-04-16 16:38   ` Arturo Borrero Gonzalez
2014-04-16 16:50     ` Patrick McHardy
2014-04-18 12:36       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416163258.GA30296@macbook.localnet \
    --to=kaber@trash.net \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.