From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/4] toolchain: add a hidden config option to enable the toolchain package
Date: Wed, 16 Apr 2014 19:43:08 +0200 [thread overview]
Message-ID: <20140416194308.1f7e75f5@skate> (raw)
In-Reply-To: <1396864610-8426-3-git-send-email-fabio.porcedda@gmail.com>
Dear Fabio Porcedda,
On Mon, 7 Apr 2014 11:56:48 +0200, Fabio Porcedda wrote:
> The usual way to enable a package using the package infrastructure is to
> use a config option so instead to add the toolchain package to the
> TARGETS variable in the Makefile add a config option like all the other
> toolchain packages.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Makefile | 2 +-
> toolchain/Config.in | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
I've applied this patch, which conflicted because it was based on the
previous patch :)
> diff --git a/Makefile b/Makefile
> index 82f2763..e0831b6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -299,7 +299,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
> #
> ################################################################################
I've removed this big comment here that was no longer making any sense.
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 44f3ac6..94a0c7d 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -1,5 +1,9 @@
> menu "Toolchain"
>
> +config BR2_TOOLCHAIN
And added a comment above this, to explain what it's useful for.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-16 17:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 9:56 [Buildroot] [PATCH v4 0/4] Miscellauneus patches Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 1/4] Makefile: fix coding style Fabio Porcedda
2014-04-16 17:42 ` Thomas Petazzoni
2014-04-17 8:21 ` Fabio Porcedda
2014-04-22 16:03 ` Arnout Vandecappelle
2014-04-22 20:16 ` Thomas Petazzoni
2014-04-22 20:28 ` Fabio Porcedda
2014-04-23 8:43 ` Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 2/4] toolchain: add a hidden config option to enable the toolchain package Fabio Porcedda
2014-04-16 17:43 ` Thomas Petazzoni [this message]
2014-04-17 8:10 ` Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 3/4] Makefile: let show-targets prints also the dependencies Fabio Porcedda
2014-04-16 17:49 ` Thomas Petazzoni
2014-04-17 9:17 ` Fabio Porcedda
2014-04-22 10:15 ` Fabio Porcedda
2014-04-23 8:46 ` Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 4/4] luajit: needs for 32bit archictectures a 32bit host gcc Fabio Porcedda
2014-04-16 17:54 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416194308.1f7e75f5@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.