From: Thierry Reding <thierry.reding@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
Duan Jiong <duanj.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
Date: Wed, 16 Apr 2014 21:49:46 +0200 [thread overview]
Message-ID: <20140416194944.GA10258@mithrandir> (raw)
In-Reply-To: <53480EB0.6050606@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 636 bytes --]
On Fri, Apr 11, 2014 at 09:48:00AM -0600, Stephen Warren wrote:
> On 04/11/2014 02:36 AM, Duan Jiong wrote:
> > This patch fixes coccinelle error regarding usage of IS_ERR and
> > PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Same comment as the other patch; I prefer the existing code (although
> I'll defer to Thierry as maintainer of both these pieces of code).
I feel the same way. And in fact I believe we already rejected a similar
a while back for the same reason.
> It would help if the commit description quoted the coccinelle error.
"Suggestion" would probably be more accurate. There is no error here.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-04-16 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 8:36 [PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO Duan Jiong
[not found] ` <1397205401-24148-1-git-send-email-duanj.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2014-04-11 15:48 ` Stephen Warren
2014-04-16 19:49 ` Thierry Reding [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-06 7:53 Duan Jiong
2013-11-06 16:49 ` Stephen Warren
[not found] ` <527A7333.9090409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-07 1:15 ` Duan Jiong
2013-11-07 1:15 ` Duan Jiong
2013-11-11 6:23 ` Thierry Reding
2013-11-11 6:23 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416194944.GA10258@mithrandir \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.