From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <pranith@gatech.edu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] kernel/rcu/rcutorture.c: use macro to define module parameter
Date: Wed, 16 Apr 2014 16:23:31 -0700 [thread overview]
Message-ID: <20140416232331.GF4496@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJhHMCBU+u6vmc+vjLCGrSytb74MmpgBCvMZVvR7o9k=3vgchA@mail.gmail.com>
On Wed, Apr 16, 2014 at 07:10:41PM -0400, Pranith Kumar wrote:
> On Wed, Apr 16, 2014 at 5:14 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> >
> > This fails for me. The problem is that the defined macro makes everything
> > static, and rcutorture_runnable is used in kernel/sysctl.c. :-/
> >
> > In theory, it would be possible to make torture_param() take "static"
> > as a parameter, but this adds more characters than it removes.
> >
>
> Oh, I just tried building it as a module and it worked. In the future
> I will run this both as inbuilt and as a module before sending any
> patches.
>
> Sorry for the noise!
This is not noise! I do intend to use it as a module in the future, so
it is helpful that you found and fixed the other bugs. I really cannot
complain about one bad patch out of several useful fixes! So please
do keep trying things and looking at things in RCU. ;-)
Thanx, Paul
prev parent reply other threads:[~2014-04-16 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 20:47 [PATCH 2/2] kernel/rcu/rcutorture.c: use macro to define module parameter Pranith Kumar
2014-04-16 21:14 ` Paul E. McKenney
2014-04-16 23:10 ` Pranith Kumar
2014-04-16 23:23 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416232331.GF4496@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pranith@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.