From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: log running test to dmesg
Date: Thu, 17 Apr 2014 09:40:27 +1000 [thread overview]
Message-ID: <20140416234027.GR15995@dastard> (raw)
In-Reply-To: <534EF81D.20205@redhat.com>
On Wed, Apr 16, 2014 at 04:37:33PM -0500, Eric Sandeen wrote:
> We already log the running test to system logs via "logger"
> but viro pointed out that we can use /dev/kmsg to insert it
> into dmesg as well. When looking at the serial console that
> could be pretty useful.
>
> Thanks to viro for the test -w suggestion too.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/check b/check
> index 268417c..09b2320 100755
> --- a/check
> +++ b/check
> @@ -457,6 +457,7 @@ do
> $timestamp && echo -n " ["`date "+%T"`"]"
> [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
> $LOGGER_PROG "run xfstest $seqnum"
> + test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
> ./$seq >$tmp.rawout 2>&1
> sts=$?
> $timestamp && _timestamp
Might it be worthwhile adding a "_log" function that can take an
arbitrary string so in future it is easy to add new log messages?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-16 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 21:37 [PATCH] xfstests: log running test to dmesg Eric Sandeen
2014-04-16 23:40 ` Dave Chinner [this message]
2014-04-17 1:43 ` Eric Sandeen
2014-07-18 4:37 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416234027.GR15995@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.