From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Serban Constantinescu" <serban.constantinescu@arm.com>,
"Arve Hjønnevåg" <arve@android.com>,
"John Stultz" <john.stultz@linaro.org>,
"Bojan Prtvar" <prtvar.b@gmail.com>,
mathieu.maret@gmail.com
Subject: Re: [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression
Date: Thu, 17 Apr 2014 02:58:10 +0300 [thread overview]
Message-ID: <20140416235810.GU26890@mwanda> (raw)
In-Reply-To: <534EEB29.9020900@gmail.com>
On Wed, Apr 16, 2014 at 10:42:17PM +0200, Yves Deweerdt wrote:
>
> __user should be kept when casting to struct binder_version *
>
>
Mathieu sent this one earlier.
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-April/048614.html
His is perfect, except that he missed the space in the ": {", but it's
still ok.
regards,
dan carpenter
> Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
> ---
> drivers/staging/android/binder.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index cfe4bc8..0f74e43 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -2683,16 +2683,21 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> binder_free_thread(proc, thread);
> thread = NULL;
> break;
> - case BINDER_VERSION:
> + case BINDER_VERSION: {
> + struct binder_version __user *bv =
> + (struct binder_version __user *)ubuf;
> +
> if (size != sizeof(struct binder_version)) {
> ret = -EINVAL;
> goto err;
> }
> - if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, &((struct binder_version *)ubuf)->protocol_version)) {
> + if (put_user(BINDER_CURRENT_PROTOCOL_VERSION,
> + &(bv->protocol_version))) {
> ret = -EINVAL;
> goto err;
> }
> break;
> + }
> default:
> ret = -EINVAL;
> goto err;
> --
> 1.8.3.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2014-04-16 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 20:42 [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression Yves Deweerdt
2014-04-16 23:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416235810.GU26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.maret@gmail.com \
--cc=prtvar.b@gmail.com \
--cc=serban.constantinescu@arm.com \
--cc=yves.deweerdt.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.