From: Greg KH <gregkh@linuxfoundation.org>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: jet.chen@intel.com, fengguang.wu@intel.com,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] FMC: misc_register should not be called while atomic
Date: Wed, 16 Apr 2014 20:09:25 -0700 [thread overview]
Message-ID: <20140417030925.GA7486@kroah.com> (raw)
In-Reply-To: <20140416223942.GA2020@mail.gnudd.com>
On Thu, Apr 17, 2014 at 12:39:42AM +0200, Alessandro Rubini wrote:
> >> --- a/drivers/fmc/fmc-chardev.c
> >> +++ b/drivers/fmc/fmc-chardev.c
> >> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc)
> >> fc->misc.fops = &fc_fops;
> >> fc->misc.name = kstrdup(dev_name(&fmc->dev), GFP_KERNEL);
> >>
> >> - spin_lock(&fc_lock);
> >> ret = misc_register(&fc->misc);
> >> + spin_lock(&fc_lock);
> >> if (ret < 0) {
> >> kfree(fc->misc.name);
> >> kfree(fc);
> >> --
> >> 1.9.1
>
> This is already applied, though in a slightly different way. Commit
> 783c2fb1b. I fixed it in Jul 13 2013 after user reports.
>
> "git tag --contains 783c2fb1b" reports v3.12-rc1 and later
Then why in the world is it being submitted as a patch to be included?
What is going on here?
confused,
greg k-h
prev parent reply other threads:[~2014-04-17 3:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 3:32 [FMC] BUG: scheduling while atomic: swapper/1/0x10000002 Jet Chen
2014-04-09 5:08 ` Alessandro Rubini
2014-04-09 5:26 ` Jet Chen
2014-04-09 5:28 ` Fengguang Wu
2014-04-09 16:44 ` Jet Chen
2014-04-09 16:46 ` Jet Chen
[not found] ` <1397016815-74608-1-git-send-email-jet.chen@intel.com>
2014-04-16 21:10 ` [PATCH] FMC: misc_register should not be called while atomic Greg Kroah-Hartman
2014-04-16 22:39 ` Alessandro Rubini
2014-04-17 3:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417030925.GA7486@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fengguang.wu@intel.com \
--cc=jet.chen@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.