From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: usage of fixed path in hotplug scripts
Date: Thu, 17 Apr 2014 16:06:14 +0200
Message-ID: <20140417140614.GA27737@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian.Campbell@citrix.com, Ian.Jackson@eu.citrix.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


Ian,

is there a reason /etc/init.d/xencommons uses a hardcoded path to
/etc/xen/scripts/hotplugpath.sh, while that file actually contains all
the variable paths? Should make install do some sort of 

        sed "s^@XEN_SCRIPT_DIR@$XEN_SCRIPT_DIR@" \
        tools/hotplug/Linux/init.d/xencommons \
        > $DESTDIR$(XENCOMMONS_INITD)/xencommons

(or whatever the correct syntax would be)

My point is that some parts of the paths can be configured, but these
paths are not used. Instead hardcoded paths are used.


Olaf