From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 12/18] drm: pass the irq explicitly to drm_irq_install Date: Thu, 17 Apr 2014 17:06:56 +0200 Message-ID: <20140417150654.GK550@ulmo> References: <1397252175-14227-1-git-send-email-daniel.vetter@ffwll.ch> <1397252175-14227-13-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0783748804==" Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id C1B436E55B for ; Thu, 17 Apr 2014 08:08:05 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id t10so795335eei.28 for ; Thu, 17 Apr 2014 08:08:04 -0700 (PDT) In-Reply-To: <1397252175-14227-13-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0783748804== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="g4MvFqI7wmANiPDo" Content-Disposition: inline --g4MvFqI7wmANiPDo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 11, 2014 at 11:36:09PM +0200, Daniel Vetter wrote: > Unfortunately this requires a drm-wide change, and I didn't see a sane > way around that. Luckily it's fairly simple, we just need to inline > the respective get_irq implementation from either drm_pci.c or > drm_platform.c. >=20 > With that we can now also remove drm_dev_to_irq from drm_irq.c. >=20 > Signed-off-by: Daniel Vetter > --- > Documentation/DocBook/drm.tmpl | 10 +--------- > drivers/gpu/drm/armada/armada_drv.c | 2 +- > drivers/gpu/drm/drm_irq.c | 13 +++---------- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > drivers/gpu/drm/i915/i915_dma.c | 2 +- > drivers/gpu/drm/i915/i915_drv.c | 4 ++-- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_irq.c | 2 +- > drivers/gpu/drm/radeon/radeon_irq_kms.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- > include/drm/drmP.h | 2 +- > 14 files changed, 17 insertions(+), 32 deletions(-) Looks good to me: Reviewed-by: Thierry Reding --g4MvFqI7wmANiPDo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTT+4OAAoJEN0jrNd/PrOhU8IP/iZFlxThwrIh3ZhZKAp83g47 9bPN+H8r0INSB603SV2yXpcxw9j+8EpmoCu/ngjrhMfXjS+MEULbwvLPaCTJ+h95 3dwq/B8UiRE5lokhK93sntCdMGv2Qrj4sPOF79NoHPOIx1ewwc0dxFynE0ocfCwQ Vet8R/5DAvJDKjH6WxJAi3P1uF8IHdexYDF1dQvJLEDHwY+TN2ufJ1Prh10y5ps8 w6Q9ZZXIn37VWMpjwVbPOk5IOaiy1qpHKlqkssliFuvfRH+EYEDdGaLNssUQgXdJ EQQXKzcmoPpqEGVXbJ227Ong75S2JYuG2/yiOOUDFJqDiWAX+0ll9pFevmVj2ECH OoPMmIckdoVAE4M/wTQIpoVA93wEX8Y1X6ku9GRlJS7ysuPGInnfg8kohB0HJNry 8VlGuAL5v8WI1GG7t+o7gGdExga05u1GihKkrHFOBELrsajexlaszP3BR1x9d06Z GijIDR71tmhCeiO58m+4SEFy439siAkUapTApObntFPMDweau93iM5h31tcaZJIH BWykH0syd7RIZI72V6GM3bC2K9g2zlNK88OIv9C08TrTgx5wzdABRU3x1B6iGQre pxukOGOgVrND5qitHAyvTgwEY9kgKICNyE/0KLz8QDdwqS4Asivta4rOvPMenjIE 3h7VZCwAhyYIs6jkAwpr =5EJt -----END PGP SIGNATURE----- --g4MvFqI7wmANiPDo-- --===============0783748804== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0783748804==--