From: Christoph Hellwig <hch@infradead.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
minchan@kernel.org, shli@kernel.org, riel@redhat.com,
sjenning@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
mgorman@suse.de, aquini@redhat.com, aarcange@redhat.com,
khalid.aziz@oracle.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/swap: cleanup *lru_cache_add* functions
Date: Fri, 18 Apr 2014 06:51:14 -0700 [thread overview]
Message-ID: <20140418135114.GA4911@infradead.org> (raw)
In-Reply-To: <1397826591-19379-1-git-send-email-nasa4836@gmail.com>
On Fri, Apr 18, 2014 at 09:09:51PM +0800, Jianyu Zhan wrote:
> In mm/swap.c, __lru_cache_add() is exported, but actually there are
> no users outside this file. However, lru_cache_add() is supposed to
> be used by vfs, or whatever others, but it is not exported.
There are no modular users of lru_cache_add, so please don't needlessly
export it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
minchan@kernel.org, shli@kernel.org, riel@redhat.com,
sjenning@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
mgorman@suse.de, aquini@redhat.com, aarcange@redhat.com,
khalid.aziz@oracle.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/swap: cleanup *lru_cache_add* functions
Date: Fri, 18 Apr 2014 06:51:14 -0700 [thread overview]
Message-ID: <20140418135114.GA4911@infradead.org> (raw)
In-Reply-To: <1397826591-19379-1-git-send-email-nasa4836@gmail.com>
On Fri, Apr 18, 2014 at 09:09:51PM +0800, Jianyu Zhan wrote:
> In mm/swap.c, __lru_cache_add() is exported, but actually there are
> no users outside this file. However, lru_cache_add() is supposed to
> be used by vfs, or whatever others, but it is not exported.
There are no modular users of lru_cache_add, so please don't needlessly
export it.
next prev parent reply other threads:[~2014-04-18 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 13:09 [PATCH] mm/swap: cleanup *lru_cache_add* functions Jianyu Zhan
2014-04-18 13:09 ` Jianyu Zhan
2014-04-18 13:51 ` Christoph Hellwig [this message]
2014-04-18 13:51 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-04-18 15:39 Jianyu Zhan
2014-04-18 15:39 ` Jianyu Zhan
2014-04-18 21:14 ` Rik van Riel
2014-04-18 21:14 ` Rik van Riel
2014-04-21 1:00 ` Zhang Yanfei
2014-04-21 1:00 ` Zhang Yanfei
2014-04-21 4:02 ` Jianyu Zhan
2014-04-21 4:02 ` Jianyu Zhan
2014-04-21 6:09 ` Zhang Yanfei
2014-04-21 6:09 ` Zhang Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418135114.GA4911@infradead.org \
--to=hch@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=nasa4836@gmail.com \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.