From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: 'Lukas Czerner' <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range()
Date: Fri, 18 Apr 2014 10:44:36 -0400 [thread overview]
Message-ID: <20140418144436.GC19131@thunk.org> (raw)
In-Reply-To: <005e01cf5a01$78bc0990$6a341cb0$@samsung.com>
On Thu, Apr 17, 2014 at 02:54:18PM +0900, Namjae Jeon wrote:
> > Currently in ext4_collapse_range() when calling ext4_es_remove_extent() to
> > remove status extents we're passing (EXT_MAX_BLOCKS - punch_start - 1)
> > in order to remove all extents from start of the collapse range to the
> > end of the file. However this is wrong because we might miss the
> > possible extent covering the last block of the file.
> >
> > Fix it by removing the -1.
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Looks good to me!
>
> Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2014-04-18 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <004401cf59ff$ff136f30$fd3a4d90$@samsung.com>
2014-04-17 5:54 ` [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range() Namjae Jeon
2014-04-18 14:44 ` Theodore Ts'o [this message]
2014-04-16 18:32 [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Lukas Czerner
2014-04-16 18:32 ` [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range() Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418144436.GC19131@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.